Merge lp://staging/~jseutter/landscape-client/invalid-integer into lp://staging/~landscape/landscape-client/trunk
Proposed by
Jerry Seutter
| Status: | Rejected |
|---|---|
| Rejected by: | David Britton |
| Proposed branch: | lp://staging/~jseutter/landscape-client/invalid-integer |
| Merge into: | lp://staging/~landscape/landscape-client/trunk |
| Diff against target: |
164 lines (+101/-7) 3 files modified
landscape/broker/config.py (+21/-5) landscape/deployment.py (+20/-2) landscape/tests/test_configuration.py (+60/-0) |
| To merge this branch: | bzr merge lp://staging/~jseutter/landscape-client/invalid-integer |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Geoff Teale (community) | Approve | ||
| Landscape | Pending | ||
|
Review via email:
|
|||
Description of the change
This branch addresses a bug caused by the exchange interval having an empty string in debconf. Trying to call landscape-config --exchange-interval "" resulted in a command line parse error. The fix changes the parsing to allow an empty string to be passed in, which causes the default setting to be used.
To post a comment you must log in.
Unmerged revisions
- 458. By Jerry Seutter
-
Adding a missing docstring.
- 457. By Jerry Seutter
-
exchange-interval, urgent-
exchange- interval and ping-interval now accept
the empty string on the command line.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
+1 Looks good to me.