Merge lp://staging/~jr/bzr-builddeb/larstiq-rename into lp://staging/bzr-builddeb
Proposed by
Jonathan Riddell
| Status: | Merged |
|---|---|
| Approved by: | Jelmer Vernooij |
| Approved revision: | 614 |
| Merged at revision: | 614 |
| Proposed branch: | lp://staging/~jr/bzr-builddeb/larstiq-rename |
| Merge into: | lp://staging/bzr-builddeb |
| Diff against target: |
281 lines (+36/-35) 5 files modified
__init__.py (+1/-1) cmds.py (+16/-16) properties.py (+4/-4) source_distiller.py (+4/-4) util.py (+11/-10) |
| To merge this branch: | bzr merge lp://staging/~jr/bzr-builddeb/larstiq-rename |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Jelmer Vernooij | Approve | ||
|
Review via email:
|
|||
Description of the change
Rename "larstiq" property to "top_level". "larstiq" is meaningless to readers of the code, it's just named after a user on launchpad, use a variable name with meaning to make code more readable.
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
This looks good, though I have to add that LarstiQ isn't just some Launchpad user, he is one of the early maintainers of bzr in Debian and was release manager for a couple of bzr releases.
(having "top_level" in quotes in the comments doesn't seem correct anymore?)