Merge lp://staging/~jpakkane/unity-notifications/simpleqml into lp://staging/unity-notifications

PASSED: Continuous integration, rev:169
http://jenkins.qa.ubuntu.com/job/unity-notifications-ci/4/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-notifications-saucy-armhf-ci/4
        deb: http://jenkins.qa.ubuntu.com/job/unity-notifications-saucy-armhf-ci/4/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-notifications-saucy-i386-ci/2

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity-notifications-ci/4/rebuild

PASSED: Continuous integration, rev:170
http://jenkins.qa.ubuntu.com/job/unity-notifications-ci/5/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-notifications-saucy-armhf-ci/5
        deb: http://jenkins.qa.ubuntu.com/job/unity-notifications-saucy-armhf-ci/5/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-notifications-saucy-i386-ci/3

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity-notifications-ci/5/rebuild

136 + SimpleQmlSender *cl = new SimpleQmlSender(engine);
137 + engine->rootContext()->setContextProperty("unity.notifications", cl);

I probably mentioned this before, but IMO our QML components should not mess with the QML engine directly if at all possible, but this is just my opinion. You might want to sync with the SDK team and ask if this is OK for them.

173 + QString app_name("client");
178 + QString app_icon;

So, there is no way for the app developer to set the app_name of app_icon? I guess these will not be visible on the notification bubble then.

183 + if(!result.isValid()) {
184 + fprintf(stderr, "Sending notification failed.\n");
185 + }

Please, use qWarning() or qCritical(). This way the application which loads this component can get the messages redirected by setting the logger handlers if needed.

> 183 + if(!result.isValid()) {
> 184 + fprintf(stderr, "Sending notification failed.\n");
> 185 + }
>
> Please, use qWarning() or qCritical(). This way the application which loads
> this component can get the messages redirected by setting the logger handlers
> if needed.

Also, provide the reply.error().name() and reply.error().message() as part of the error message.

If you include <QDebug> you also get operator<< for the qWarning(), qCritical(), etc. which makes your life a lot easier:

    qCritical() << "Sending notification failed:" << reply.error().name() << reply.error().message();

I havent tested, but it's possible that you can even do:

    qCritical() << "Sending notification failed:" << reply.error();

Fixed. App icon is still not settable and will not be.

PASSED: Continuous integration, rev:173
http://jenkins.qa.ubuntu.com/job/unity-notifications-ci/6/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-notifications-saucy-armhf-ci/6
        deb: http://jenkins.qa.ubuntu.com/job/unity-notifications-saucy-armhf-ci/6/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-notifications-saucy-i386-ci/4

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity-notifications-ci/6/rebuild

132 - qmlRegisterUncreatableType<NotificationClient>(uri, 1, 0, "NotificationClient", "");
133 + qmlRegisterSingletonType<SimpleQmlSender>(uri, 1, 0, "unity.notifications", senderProvider);

Why this? QML types are supposed to be uppercase and the . is really confusing (if it works at all) because usually its the delimiter for named imports.

=====

I'd fancy a test :)