Music Lens

Merge lp://staging/~jpakkane/unity-lens-music/radio-preview into lp://staging/unity-lens-music

  1. radio-preview
  2. Merge into trunk
Proposed by Jussi Pakkanen
Status: Rejected
Rejected by: Michal Hruby
Proposed branch: lp://staging/~jpakkane/unity-lens-music/radio-preview
Merge into: lp://staging/unity-lens-music
Diff against target: 24 lines (+14/-0)
1 file modified
src/rhythmbox-scope.vala (+14/-0)
To merge this branch: bzr merge lp://staging/~jpakkane/unity-lens-music/radio-preview
Reviewer Review Type Date Requested Status
Paweł Stołowski (community) Needs Information
Review via email: mp+123071@code.staging.launchpad.net

Description of the change

Adds simple preview for Internet radio stations.

Assumes that any thing to be previewed that is not explicitly handled otherwise is a radio station.

Causes the following to be printed to stdout when run:

(process:20883): libunity-WARNING **: unity-lens-private.vala:533: Unable to find scope for activation request: 0x2064b60:http://network.absoluteradio.co.uk/core/audio/ogg/live.pls?service=vcbb

To post a comment you must log in.
Revision history for this message
Paweł Stołowski (stolowski) wrote :

Looking good, I don't think there is anything else we could do for radio station preview. I also checked if gst-launch playbin uri=<radio uri> is able to play raio streams, but it isn't, so it looks like we can't easily support this via our music-preview-player.

Can you check with design if they're ok with how radio previews look?

Also:
+ // FIXME, check that this is a radio station.

is it possible to fix now without major refactoring of rhythmbox-collection? Perhaps just checking for http://?

review: Needs Information
Revision history for this message
Jussi Pakkanen (jpakkane) wrote :

What is the correct way to ask for design's approval.

I thought about checking for http, but AFAIK radio stations can also be served by UDP, RTSP or something else. Which ones are supported? Can there be http addresses that are not radio streams (theoretically: playing mp3 files from a web server)?

Revision history for this message
Michal Hruby (mhr3) wrote :

Rejecting as there are no radio stations anymore.

Unmerged revisions

101. By Jussi Pakkanen

Have previews for radio stations.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: