Thumbnailer

Merge lp://staging/~jpakkane/thumbnailer/standalone-albumart into lp://staging/thumbnailer

  1. standalone-albumart
  2. Merge into trunk
Proposed by Jussi Pakkanen
Status: Rejected
Rejected by: Jussi Pakkanen
Proposed branch: lp://staging/~jpakkane/thumbnailer/standalone-albumart
Merge into: lp://staging/thumbnailer
Diff against target: 158 lines (+73/-11)
3 files modified
src/thumbnailer.cpp (+47/-10)
src/videoscreenshotter.cpp (+1/-1)
tests/basic.cpp (+25/-0)
To merge this branch: bzr merge lp://staging/~jpakkane/thumbnailer/standalone-albumart
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Unity Team Pending
Review via email: mp+235637@code.staging.launchpad.net

Commit message

Load album art from standalone image files.

Description of the change

Load album art from standalone image files.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:104
http://jenkins.qa.ubuntu.com/job/thumbnailer-ci/96/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/thumbnailer-utopic-amd64-ci/45
    SUCCESS: http://jenkins.qa.ubuntu.com/job/thumbnailer-utopic-armhf-ci/44
        deb: http://jenkins.qa.ubuntu.com/job/thumbnailer-utopic-armhf-ci/44/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/thumbnailer-utopic-i386-ci/41

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/thumbnailer-ci/96/rebuild

review: Approve (continuous-integration)
Revision history for this message
Andrew Hayzen (ahayzen) wrote :

Do you mind making it case insensitive (or at least support title case), if it isn't already, so it doesn't matter if you have done Folder or folder etc?

lp://staging/~jpakkane/thumbnailer/standalone-albumart updated
105. By Jussi Pakkanen

Now with case insensitivity.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:105
http://jenkins.qa.ubuntu.com/job/thumbnailer-ci/97/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/thumbnailer-utopic-amd64-ci/46
    SUCCESS: http://jenkins.qa.ubuntu.com/job/thumbnailer-utopic-armhf-ci/45
        deb: http://jenkins.qa.ubuntu.com/job/thumbnailer-utopic-armhf-ci/45/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/thumbnailer-utopic-i386-ci/42

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/thumbnailer-ci/97/rebuild

review: Approve (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:105
http://jenkins.qa.ubuntu.com/job/thumbnailer-ci/98/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/thumbnailer-utopic-amd64-ci/47
    SUCCESS: http://jenkins.qa.ubuntu.com/job/thumbnailer-utopic-armhf-ci/46
        deb: http://jenkins.qa.ubuntu.com/job/thumbnailer-utopic-armhf-ci/46/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/thumbnailer-utopic-i386-ci/43

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/thumbnailer-ci/98/rebuild

review: Approve (continuous-integration)
Revision history for this message
Jussi Pakkanen (jpakkane) wrote :

We decided to to this in Mediascanner instead:

https://code.launchpad.net/~jpakkane/mediascanner2/standalone-art-uri/+merge/244588

Unmerged revisions

105. By Jussi Pakkanen

Now with case insensitivity.

104. By Jussi Pakkanen

Load album art from a standalone image file.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: