Merge lp://staging/~jpakkane/evemu/touchviewer into lp://staging/evemu
Proposed by
Jussi Pakkanen
| Status: | Needs review |
|---|---|
| Proposed branch: | lp://staging/~jpakkane/evemu/touchviewer |
| Merge into: | lp://staging/evemu |
| Diff against target: |
501 lines (+487/-0) 3 files modified
tools/eventparser.py (+240/-0) tools/eventviewer.glade (+57/-0) tools/eventviewer.py (+190/-0) |
| To merge this branch: | bzr merge lp://staging/~jpakkane/evemu/touchviewer |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| PS Jenkins bot (community) | continuous-integration | Needs Fixing | |
| Chase Douglas (community) | Needs Fixing | ||
|
Review via email:
|
|||
Description of the change
This branch adds the touch viewer application originally developed under Grail: https:/
It reads the touches data from a trace file and plots it graphically. It parses the data file itself rather than use evemu's output. The main reason for this being that there are no Python bindings for evemu as of yet.
The app can be extended to have an evemu output backend when the bindings appear. It could even parse both at the same time and plot their results next to each other, making debugging easier.
To post a comment you must log in.
Revision history for this message
| Stephen M. Webb (bregma) wrote | # |
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Needs Fixing
(continuous-integration)
Unmerged revisions
- 42. By Jussi Pakkanen
-
Imported touch viewer from Grail repo.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Just to carry over from the previous review, I think the concept is good but it should use the evemu library to get the events. That means it's blocked on adding python bindings to evemu.
I don't think it would be too difficult to add python bindings. If for some reason it is, we can revisit whether to merge this without the evemu library linkage.