Juju Charms Collection
python-moinmoin package

Merge lp://staging/~jose/charms/precise/python-moinmoin/refactor-tests into lp://staging/charms/python-moinmoin

  1. Precise Pangolin (12.04)
  2. refactor-tests
  3. Merge into trunk
Proposed by José Antonio Rey
Status: Merged
Merged at revision: 11
Proposed branch: lp://staging/~jose/charms/precise/python-moinmoin/refactor-tests
Merge into: lp://staging/charms/python-moinmoin
Diff against target: 276 lines (+57/-169)
6 files modified
README.md (+3/-3)
hooks/hooks.py (+1/-1)
tests/00-setup (+5/-0)
tests/01_deploy.test (+0/-119)
tests/10-deploy (+48/-0)
tests/get-unit-info (+0/-46)
To merge this branch: bzr merge lp://staging/~jose/charms/precise/python-moinmoin/refactor-tests
Reviewer Review Type Date Requested Status
Charles Butler (community) Approve
Adam Israel (community) Approve
Review Queue (community) automated testing Needs Fixing
Review via email: mp+248330@code.staging.launchpad.net
To post a comment you must log in.
Revision history for this message
Review Queue (review-queue) wrote :

This items has failed automated testing! Results available here http://reports.vapour.ws/charm-tests/charm-bundle-test-11017-results

review: Needs Fixing (automated testing)
Revision history for this message
Adam Israel (aisrael) wrote :

Hi José,

I had the opportunity to review this merge proposal today. I'm happy to report that all changes look good, and the tests are passing.

LGTM. +1

review: Approve
Revision history for this message
Charles Butler (lazypower) wrote :

Thanks for the reviews adam, I've taken action on this MP based on your review.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: