Juju Charms Collection
owncloud package

Merge lp://staging/~jose/charms/precise/owncloud/fix-tests into lp://staging/charms/owncloud

  1. Precise Pangolin (12.04)
  2. fix-tests
  3. Merge into trunk
Proposed by José Antonio Rey
Status: Work in progress
Proposed branch: lp://staging/~jose/charms/precise/owncloud/fix-tests
Merge into: lp://staging/charms/owncloud
Diff against target: 100 lines (+13/-46)
1 file modified
tests/100-deploy.py (+13/-46)
To merge this branch: bzr merge lp://staging/~jose/charms/precise/owncloud/fix-tests
Reviewer Review Type Date Requested Status
Charles Butler (community) Needs Fixing
Review Queue (community) automated testing Needs Fixing
Review via email: mp+246610@code.staging.launchpad.net

Description of the change

Fixed failing ownCloud automated tests.

To post a comment you must log in.
Revision history for this message
Review Queue (review-queue) wrote :

This items has failed automated testing! Results available here http://reports.vapour.ws/charm-tests/charm-bundle-test-10954-results

review: Needs Fixing (automated testing)
Reply
Revision history for this message
Charles Butler (lazypower) wrote :

Greetings Jose,

The test cleanup seems like a big deletion. And I see why as the NFS bits were difficult to nail down. However - it appears that the landscape has shifted a bit and the Owncloud GPG key hash has changed which caused the test to fail out of the gate.

unit-owncloud-0[6796]: 2015-02-17 18:06:09 INFO unit.owncloud/0.juju-log cmd.go:247 Apt key verification failed, failing hook.

Thanks again for the submission. I'm going to change status of this MP to "needs work" and when you're ready switch merge status to 'needs review' and someone will be along shortly to review your work.

If you have any questions/comments/concerns about the review contact us in #juju on irc.freenode.net or email the mailing list <email address hidden>, or ask a question tagged with "juju" on http://askubuntu.com.

review: Needs Fixing
Reply
Revision history for this message
Charles Butler (lazypower) wrote :

Heyo Jose,

I re-ran these tests and it appears they are still failing due to a new reason now.

http://paste.ubuntu.com/10664439/

I'm going to mark this as needs work. Thanks for the contribution, you're getting really close.

review: Needs Fixing
Reply

Unmerged revisions

30. By José Antonio Rey

Fully fixed ownCloud tests

29. By José Antonio Rey

Initial try to fix the ownCloud tests

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes:
to status/vote changes: