Merge lp://staging/~jose/charms/precise/jenkins-slave/1297601-fix into lp://staging/charms/jenkins-slave
Proposed by
José Antonio Rey
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Merged at revision: | 11 | ||||
| Proposed branch: | lp://staging/~jose/charms/precise/jenkins-slave/1297601-fix | ||||
| Merge into: | lp://staging/charms/jenkins-slave | ||||
| Diff against target: |
627 lines (+599/-1) 3 files modified
config.yaml (+1/-0) icon.svg (+596/-0) metadata.yaml (+2/-1) |
||||
| To merge this branch: | bzr merge lp://staging/~jose/charms/precise/jenkins-slave/1297601-fix | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Marco Ceppi (community) | Approve | ||
| Charles Butler (community) | Needs Fixing | ||
|
Review via email:
|
|||
Commit message
Added icon, blank default on config.yaml and fixed metadata.yaml
Description of the change
Charmworld reports the following errors:
err: Unknown root metadata field (ensemble)
warn: Metadata is missing categories.
warn: No icon.svg file.
warn: no README file
warn: config.yaml: option labels does not have the keys: default
Fixed all of them.
To post a comment you must log in.
Revision history for this message
| José Antonio Rey (jose) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Greetings Jose,
Thank you for this submission! I've reviewed the changes and have the following notes:
The README doesn't really tell the user anything about the configuration options, or how to deploy the jenkins slave charm and how it relates to Jenkins master.
The icon should match the Jenkins master charm icon, with the addition of a callout that its the slave charm (akin to the slave text you have at the base of this icon).
Thanks again for the submission. I'm going to change status of this MP to "needs work" and when you're ready for another review please click the "Request another review" button in the upper right hand corner of the commit message.
If you have any questions/