Juju Charms Collection
buildbot-slave package

Merge lp://staging/~jose/charms/precise/buildbot-slave/1297562-fix into lp://staging/~charmers/charms/precise/buildbot-slave/trunk

  1. Precise Pangolin (12.04)
  2. 1297562-fix
  3. Merge into trunk
Proposed by José Antonio Rey
Status: Work in progress
Proposed branch: lp://staging/~jose/charms/precise/buildbot-slave/1297562-fix
Merge into: lp://staging/~charmers/charms/precise/buildbot-slave/trunk
Diff against target: 438 lines (+340/-35)
5 files modified
README.md (+32/-0)
README.txt (+0/-35)
config.yaml (+6/-0)
icon.svg (+300/-0)
metadata.yaml (+2/-0)
To merge this branch: bzr merge lp://staging/~jose/charms/precise/buildbot-slave/1297562-fix
Reviewer Review Type Date Requested Status
Charles Butler (community) Needs Fixing
Review via email: mp+212752@code.staging.launchpad.net

Commit message

Added categories, icon and blank defaults where missing, reformatted README file to Markdown

Description of the change

Charmworld reports the following errors:

    err: Charms need a maintainer (See RFC2822) - Name <email>
    warn: Metadata is missing categories.
    warn: No icon.svg file.
    warn: config.yaml: option script-args does not have the keys: default
    warn: config.yaml: option extra-packages does not have the keys: default
    warn: config.yaml: option script-path does not have the keys: default
    warn: config.yaml: option builders does not have the keys: default
    warn: config.yaml: option extra-repository does not have the keys: default
    warn: config.yaml: option script-url does not have the keys: default

Fixed all of them except 'needs maintainer' (see bug #1028192), and reformatted README to Markdown.

To post a comment you must log in.
Revision history for this message
Charles Butler (lazypower) wrote :

Thanks for the submission Jose!

Same as buildbot master, the README makes reference to Oneric, and this is a precise series charm. This will need to be updated.

Thanks again for the submission. I'm going to change status of this MP to "needs work" and when you're ready for another review please click the "Request another review" button in the upper right hand corner of the commit message.

If you have any questions/comments/concerns about the review contact us in #juju on irc.freenode.net or email the mailing list <email address hidden>

Thanks Again!

review: Needs Fixing
Reply
Revision history for this message
Adam Israel (aisrael) wrote :

Hi Jose. Thanks for the work on this. It's been in the queue for a while. If it's still valid, that's fine. We'll move it to work in process. When you're ready for another review, please move the status back to needs review. If it's no longer valid, please move it to rejected and we'll treat it as such.

Reply

Unmerged revisions

24. By José Antonio Rey

Added categories, icon and blank defaults where missing, reformatted README file to Markdown

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: