Merge lp://staging/~jose/charms/precise/bip/1297544-fix into lp://staging/charms/bip
Proposed by
José Antonio Rey
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Merged at revision: | 17 | ||||
| Proposed branch: | lp://staging/~jose/charms/precise/bip/1297544-fix | ||||
| Merge into: | lp://staging/charms/bip | ||||
| Diff against target: |
54 lines (+5/-5) 4 files modified
README.md (+1/-1) config.yaml (+1/-1) hooks/hooks.py (+2/-2) templates/bip_conf.template (+1/-1) |
||||
| To merge this branch: | bzr merge lp://staging/~jose/charms/precise/bip/1297544-fix | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Marco Ceppi (community) | Approve | ||
|
Review via email:
|
|||
Commit message
Changed option ip to listenip
Description of the change
Changed option ip to listenip
To post a comment you must log in.
Revision history for this message
| Antonio Rosales (arosales) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Jose,
Thanks for taking the time to improve the Bip charm. Your contribution to improve the Bip charm quality is much appreciated. I too saw this problem with Bip and deduced that charm proof wanted a yaml key that had 3 characters or greater, less than 3 characters filed proof. Your fix resolves that issue.
# I am providing a initial +1 review. A ~charmer will give a final review and merge this request if they don't have any additional feedback.
## Review points:
- charm proof bip' now pass
- deployment in EC2 successful
- I can successfully set the listen port.
### In summary this update to Bip lgtm, and makes charm proof happy.
-thanks,
Atnonio