Merge lp://staging/~jorge/pyjuju/default-to-packages into lp://staging/~charm-contributors/pyjuju/docs

Proposed by Jorge Castro
Status: Needs review
Proposed branch: lp://staging/~jorge/pyjuju/default-to-packages
Merge into: lp://staging/~charm-contributors/pyjuju/docs
Diff against target: 55 lines (+11/-11)
2 files modified
source/policy.rst (+11/-7)
source/provider-configuration-openstack.rst (+0/-4)
To merge this branch: bzr merge lp://staging/~jorge/pyjuju/default-to-packages
Reviewer Review Type Date Requested Status
Clint Byrum (community) Needs Fixing
Juan L. Negron (community) Approve
Review via email: mp+126784@code.staging.launchpad.net

Description of the change

Please don't merge yet while discussion happens on the juju list.

To post a comment you must log in.
Revision history for this message
Juan L. Negron (negronjl) wrote :

Looks good to me.

-Juan

review: Approve
Revision history for this message
Juan L. Negron (negronjl) wrote :

We should get more people's comments/reviews here before merging.

-Juan

Revision history for this message
Clint Byrum (clint-fewbar) wrote :

I would change:

If the service is seeded

to

If the principal software needed to provide the service is available in a seeded package

Also it would be useful if you did the other 3 changes in a separate branch which this merge proposal can depend on. Its somewhat distracting seeing all of the changes at once here.

review: Needs Fixing
Revision history for this message
Clint Byrum (clint-fewbar) wrote :

<poke> Whats the status on this?

Unmerged revisions

74. By Jorge Castro

* Revised policy to "must" default to packages if the service is in main.

73. By Jorge Castro

Fix up some footnotes

72. By Jorge Castro

* Be explicit about defaulting charms to packaged versions if in main?

71. By Jorge Castro

Remove mention of default-instance-type, this should be managed via constraints.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches