Juju Charms Collection
mysql package

Merge lp://staging/~jorge/charms/precise/mysql/fix-metadata into lp://staging/charms/mysql

  1. Precise Pangolin (12.04)
  2. fix-metadata
  3. Merge into trunk
Proposed by Jorge Castro
Status: Merged
Merge reported by: Tim Van Steenburgh
Merged at revision: not available
Proposed branch: lp://staging/~jorge/charms/precise/mysql/fix-metadata
Merge into: lp://staging/charms/mysql
Diff against target: 34 lines (+4/-2)
2 files modified
config.yaml (+2/-0)
metadata.yaml (+2/-2)
To merge this branch: bzr merge lp://staging/~jorge/charms/precise/mysql/fix-metadata
Reviewer Review Type Date Requested Status
Tim Van Steenburgh (community) Approve
Review Queue (community) automated testing Needs Fixing
Review via email: mp+239391@code.staging.launchpad.net

Description of the change

Fix metadata to pass proof.

To post a comment you must log in.
Revision history for this message
Review Queue (review-queue) wrote :

This items has failed automated testing! Results available here http://reports.vapour.ws/charm-tests/charm-bundle-test-1280-results

review: Needs Fixing (automated testing)
Revision history for this message
Tim Van Steenburgh (tvansteenburgh) wrote :

Default keys were handled in a prior commit but I merged the tags change. Note that when adding default keys where none previously existed:

default:

should be used instead of

default: ""

They are not the same thing, and it is possible to inadvertently break the charm by using the second form.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches