Merge lp://staging/~jordy-provost/terminator/custom_commands_submenus into lp://staging/terminator/gtk3

Proposed by Jordy PROVOST
Status: Needs review
Proposed branch: lp://staging/~jordy-provost/terminator/custom_commands_submenus
Merge into: lp://staging/terminator/gtk3
Diff against target: 896 lines (+436/-394)
1 file modified
terminatorlib/plugins/custom_commands.py (+436/-394)
To merge this branch: bzr merge lp://staging/~jordy-provost/terminator/custom_commands_submenus
Reviewer Review Type Date Requested Status
Alexander van Teijlingen (community) Approve
Jordy PROVOST (community) Approve
Terminator Pending
Review via email: mp+351362@code.staging.launchpad.net

Commit message

- Permit to create submenus in a more graphical way (instead of using '/' in command names)
- Fixes for indentation coherence (first level is 4 spaces, second is 8, third is 12, etc...)
- Clean some trailing spaces, and spaces only lines

To post a comment you must log in.
Revision history for this message
Jordy PROVOST (jordy-provost) wrote :

Tested on Debian Stretch and Buster without any problem.
Indentation fix does not change the behaviour but improve readability for further changes.

review: Approve
Revision history for this message
Alexander van Teijlingen (a.vant) wrote :

Also tested on Debian [9] Stretch and working

x86_64 & python2

Good feature imo

review: Approve
Revision history for this message
Bryce Harrington (bryce) wrote :

Unfortunately the whitespace changes make it hard to spot the actual code changes, but conceptually this sounds interesting.

Revision history for this message
Jordy PROVOST (jordy-provost) wrote :

Ok, since the review is still pending, i suppose that the merge will not be accepted ?

Unfortunately, i will be forced to maintain a confidential/personnal fork of this addon (i must use it for my everyday's work as my custom commands config file contains 66 entries - and the "/" thing seems like a workaround). :'(

Unmerged revisions

1804. By Jordy PROVOST

Add graphical way to create submenus and fixes for identation coherence (4spaces)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: