ubuntu-system-settings

Merge lp://staging/~jonas-drange/ubuntu-system-settings/printers into lp://staging/ubuntu-system-settings

  1. printers
  2. Merge into trunk
Proposed by Jonas G. Drange
Status: Merged
Approved by: Andrew Hayzen
Approved revision: 1779
Merged at revision: 1769
Proposed branch: lp://staging/~jonas-drange/ubuntu-system-settings/printers
Merge into: lp://staging/ubuntu-system-settings
Diff against target: 1715 lines (+1561/-1)
21 files modified
debian/control (+1/-0)
plugins/CMakeLists.txt (+1/-0)
plugins/brightness/brightness.settings (+1/-1)
plugins/mouse/mouse.settings (+1/-0)
plugins/printing/AddPrinter.qml (+144/-0)
plugins/printing/AddPrinterDetails.qml (+316/-0)
plugins/printing/CMakeLists.txt (+29/-0)
plugins/printing/PageComponent.qml (+206/-0)
plugins/printing/Printer.qml (+141/-0)
plugins/printing/PrinterConnection.qml (+71/-0)
plugins/printing/Setting.qml (+63/-0)
plugins/printing/TextBoxListItem.qml (+59/-0)
plugins/printing/printer-sub-pages/CopiesAndPages.qml (+51/-0)
plugins/printing/printer-sub-pages/GeneralSettings.qml (+84/-0)
plugins/printing/printer-sub-pages/Policies.qml (+77/-0)
plugins/printing/printer-sub-pages/Status.qml (+92/-0)
plugins/printing/printing.settings (+25/-0)
plugins/printing/printing.svg (+188/-0)
src/main.cpp (+3/-0)
src/qml/MainWindow.qml (+6/-0)
src/url-map.ini (+2/-0)
To merge this branch: bzr merge lp://staging/~jonas-drange/ubuntu-system-settings/printers
Reviewer Review Type Date Requested Status
system-apps-ci-bot continuous-integration Approve
Andrew Hayzen (community) Approve
Review via email: mp+315339@code.staging.launchpad.net

Commit message

adds printing panel

To post a comment you must log in.
Revision history for this message
system-apps-ci-bot (system-apps-ci-bot) wrote :

PASSED: Continuous integration, rev:1777
https://jenkins.canonical.com/system-apps/job/lp-ubuntu-system-settings-ci/18/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build/2346
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-0-fetch/2346
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial+overlay/2164
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial+overlay/2164/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=zesty/2164
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=zesty/2164/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial+overlay/2164
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial+overlay/2164/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=zesty/2164
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=zesty/2164/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial+overlay/2164
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial+overlay/2164/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=zesty/2164
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=zesty/2164/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-apps/job/lp-ubuntu-system-settings-ci/18/rebuild

review: Approve (continuous-integration)
lp://staging/~jonas-drange/ubuntu-system-settings/printers updated
1778. By Jonas G. Drange

fixes selecting category by URL

1779. By Jonas G. Drange

makes sure the detailsPageObserver target is set on manual addition

Revision history for this message
system-apps-ci-bot (system-apps-ci-bot) wrote :

PASSED: Continuous integration, rev:1778
https://jenkins.canonical.com/system-apps/job/lp-ubuntu-system-settings-ci/19/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build/2352
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-0-fetch/2352
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial+overlay/2170
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial+overlay/2170/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=zesty/2170
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=zesty/2170/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial+overlay/2170
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial+overlay/2170/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=zesty/2170
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=zesty/2170/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial+overlay/2170
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial+overlay/2170/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=zesty/2170
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=zesty/2170/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-apps/job/lp-ubuntu-system-settings-ci/19/rebuild

review: Approve (continuous-integration)
Revision history for this message
Andrew Hayzen (ahayzen) wrote :

Does the .pot need updating due to the new UI strings?

review: Needs Information
Revision history for this message
Andrew Hayzen (ahayzen) wrote :

LGTM, (.pot is automatically updated apparently) a few things could be improved in a 2nd phase

- if there is only one driver it should probably autoselect it
- the selected driver is not that obvious
- ppd file could be imported via content-hub
- if a printer already exists with the same name when adding, it seems to just overwrite it and not prompt you. Also would be nice as if the printer name field when typing went red or something to tell you there is an existing printer.
- the issues we noted in the todo list :-)

review: Approve
Revision history for this message
system-apps-ci-bot (system-apps-ci-bot) wrote :

PASSED: Continuous integration, rev:1779
https://jenkins.canonical.com/system-apps/job/lp-ubuntu-system-settings-ci/20/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build/2353
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-0-fetch/2353
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial+overlay/2171
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial+overlay/2171/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=zesty/2171
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=zesty/2171/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial+overlay/2171
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial+overlay/2171/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=zesty/2171
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=zesty/2171/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial+overlay/2171
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial+overlay/2171/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=zesty/2171
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=zesty/2171/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-apps/job/lp-ubuntu-system-settings-ci/20/rebuild

review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches