ubuntu-system-settings

Merge lp://staging/~jonas-drange/ubuntu-system-settings/brightness-qml-testing into lp://staging/ubuntu-system-settings

  1. brightness-qml-testing
  2. Merge into trunk
Proposed by Jonas G. Drange
Status: Approved
Approved by: Ken VanDine
Approved revision: 1734
Proposed branch: lp://staging/~jonas-drange/ubuntu-system-settings/brightness-qml-testing
Merge into: lp://staging/ubuntu-system-settings
Diff against target: 1355 lines (+1131/-20)
27 files modified
debian/control (+1/-0)
plugins/brightness/CMakeLists.txt (+1/-1)
plugins/brightness/PageComponent.qml (+3/-0)
plugins/brightness/WifiDisplays.qml (+22/-19)
tests/mocks/CMakeLists.txt (+1/-0)
tests/mocks/GSettings1.0/CMakeLists.txt (+19/-0)
tests/mocks/GSettings1.0/fake_gsettings.cpp (+127/-0)
tests/mocks/GSettings1.0/fake_gsettings.h (+101/-0)
tests/mocks/GSettings1.0/plugin.cpp (+35/-0)
tests/mocks/GSettings1.0/plugin.h (+33/-0)
tests/mocks/GSettings1.0/qmldir (+2/-0)
tests/mocks/Ubuntu/SystemSettings/Brightness/CMakeLists.txt (+20/-0)
tests/mocks/Ubuntu/SystemSettings/Brightness/MockAethercastDevice.h (+63/-0)
tests/mocks/Ubuntu/SystemSettings/Brightness/MockAethercastDeviceModel.cpp (+95/-0)
tests/mocks/Ubuntu/SystemSettings/Brightness/MockAethercastDeviceModel.h (+63/-0)
tests/mocks/Ubuntu/SystemSettings/Brightness/MockAethercastDisplays.cpp (+89/-0)
tests/mocks/Ubuntu/SystemSettings/Brightness/MockAethercastDisplays.h (+96/-0)
tests/mocks/Ubuntu/SystemSettings/Brightness/MockBrightness.cpp (+51/-0)
tests/mocks/Ubuntu/SystemSettings/Brightness/MockBrightness.h (+58/-0)
tests/mocks/Ubuntu/SystemSettings/Brightness/plugin.cpp (+33/-0)
tests/mocks/Ubuntu/SystemSettings/Brightness/plugin.h (+33/-0)
tests/mocks/Ubuntu/SystemSettings/Brightness/qmldir (+2/-0)
tests/mocks/Ubuntu/SystemSettings/CMakeLists.txt (+1/-0)
tests/plugins/CMakeLists.txt (+10/-0)
tests/plugins/brightness/Source/qmldir (+3/-0)
tests/plugins/brightness/tst_BrightnessPageComponent.qml (+90/-0)
tests/plugins/brightness/tst_BrightnessWifiDisplays.qml (+79/-0)
To merge this branch: bzr merge lp://staging/~jonas-drange/ubuntu-system-settings/brightness-qml-testing
Reviewer Review Type Date Requested Status
Ken VanDine Approve
system-apps-ci-bot continuous-integration Needs Fixing
Review via email: mp+308508@code.staging.launchpad.net

Commit message

* mocks brightness panel plugin
* mocks aethercast plugin
* adds qml-test infrastructure for the brightness plugin in addition to some tests

Description of the change

This is not a complete set of tests for the current brightness panel, but rather a small set such that the review process is easier.

To post a comment you must log in.
Revision history for this message
Jonas G. Drange (jonas-drange) :
Reply
Revision history for this message
system-apps-ci-bot (system-apps-ci-bot) wrote :

FAILED: Continuous integration, rev:1731
https://jenkins.canonical.com/system-apps/job/lp-ubuntu-system-settings-ci/210/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/system-apps/job/build/1845/console
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-0-fetch/1846
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=vivid+overlay/1686/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1686/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=yakkety/1686/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=vivid+overlay/1686/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1686/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=yakkety/1686/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=vivid+overlay/1686/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial+overlay/1686/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=yakkety/1686/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-apps/job/lp-ubuntu-system-settings-ci/210/rebuild

review: Needs Fixing (continuous-integration)
Reply
Revision history for this message
system-apps-ci-bot (system-apps-ci-bot) wrote :

FAILED: Continuous integration, rev:1732
https://jenkins.canonical.com/system-apps/job/lp-ubuntu-system-settings-ci/212/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/system-apps/job/build/1849/console
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-0-fetch/1850
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=vivid+overlay/1690/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1690/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=yakkety/1690/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=vivid+overlay/1690/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1690/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=yakkety/1690/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=vivid+overlay/1690/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial+overlay/1690/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=yakkety/1690/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-apps/job/lp-ubuntu-system-settings-ci/212/rebuild

review: Needs Fixing (continuous-integration)
Reply
Revision history for this message
system-apps-ci-bot (system-apps-ci-bot) wrote :

FAILED: Continuous integration, rev:1734
https://jenkins.canonical.com/system-apps/job/lp-ubuntu-system-settings-ci/214/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/system-apps/job/build/1862/console
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-0-fetch/1863
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=vivid+overlay/1703
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=vivid+overlay/1703/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1703
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1703/artifact/output/*zip*/output.zip
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=yakkety/1703/console
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=vivid+overlay/1703
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=vivid+overlay/1703/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1703
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1703/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=yakkety/1703
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=yakkety/1703/artifact/output/*zip*/output.zip
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=vivid+overlay/1703/console
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial+overlay/1703
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial+overlay/1703/artifact/output/*zip*/output.zip
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=yakkety/1703/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-apps/job/lp-ubuntu-system-settings-ci/214/rebuild

review: Needs Fixing (continuous-integration)
Reply
Revision history for this message
Jonas G. Drange (jonas-drange) wrote :

These test failures are addressed in silo 2066.

Reply
Revision history for this message
Ken VanDine (ken-vandine) wrote :

Looks good

review: Approve
Reply

Unmerged revisions

1734. By Jonas G. Drange

add includes

1733. By Jonas G. Drange

add fake gsettings

1732. By Jonas G. Drange

remove unused flags

1731. By Jonas G. Drange

add test that uses a model

1730. By Jonas G. Drange

add wifi displays test

1729. By Jonas G. Drange

add mock, test

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches