Merge lp://staging/~jonas-drange/ubuntu-system-settings/apn-prototype into lp://staging/ubuntu-system-settings
Proposed by
Jonas G. Drange
| Status: | Merged | ||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Merged at revision: | 1488 | ||||||||||||||||||||||||||||||||
| Proposed branch: | lp://staging/~jonas-drange/ubuntu-system-settings/apn-prototype | ||||||||||||||||||||||||||||||||
| Merge into: | lp://staging/ubuntu-system-settings | ||||||||||||||||||||||||||||||||
| Diff against target: |
3490 lines (+2067/-1143) 16 files modified
plugins/cellular/CMakeLists.txt (+3/-4) plugins/cellular/Components/CMakeLists.txt (+3/-0) plugins/cellular/Components/KeyboardRectangle.qml (+74/-0) plugins/cellular/Components/LabelTextField.qml (+54/-0) plugins/cellular/Components/StandardAnimation.qml (+22/-0) plugins/cellular/PageApnEditor.qml (+394/-346) plugins/cellular/PageChooseApn.qml (+333/-535) plugins/cellular/apn_editor.js (+192/-0) plugins/cellular/apn_manager.js (+588/-60) plugins/cellular/ofonoactivator.cpp (+0/-132) plugins/cellular/ofonoactivator.h (+0/-42) plugins/cellular/plugin.cpp (+0/-2) tests/autopilot/ubuntu_system_settings/__init__.py (+147/-1) tests/autopilot/ubuntu_system_settings/tests/__init__.py (+17/-21) tests/autopilot/ubuntu_system_settings/tests/ofono.py (+99/-0) tests/autopilot/ubuntu_system_settings/tests/test_cellular.py (+141/-0) |
||||||||||||||||||||||||||||||||
| To merge this branch: | bzr merge lp://staging/~jonas-drange/ubuntu-system-settings/apn-prototype | ||||||||||||||||||||||||||||||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Ken VanDine | Approve | ||
| PS Jenkins bot | continuous-integration | Needs Fixing | |
| Alfonso Sanchez-Beato | mms/nuntium interactions | Pending | |
| Tony Espy | sanity | Pending | |
| Matthew Paul Thomas | design | Pending | |
|
Review via email:
|
|||
Commit message
[cellular/apn] new APN panel made for the new 'Preferred' property, as well as the 'ResetContext' method.
Description of the change
New UI due to new NetworkManager, Nuntium and Ofono backend.
Silo: 33
* Is your branch in sync with latest trunk (e.g. bzr pull lp:trunk -> no changes)
Yes
* Did you build your software in a clean sbuild/pbuilder chroot or ppa?
Yes
* Did you build your software in a clean sbuild/pbuilder armhf chroot or ppa?
Yes
* Has your component "TestPlan” been executed successfully on emulator, N4?
No, it's currently being written AND the NetworkManager backend change has not landed yet.
* Has a 5 minute exploratory testing run been executed on N4?
N/A
* If you changed the packaging (debian), did you subscribe a core-dev to this MP?
Yes, kenvandine
* If you changed the UI, did you subscribe the design-reviewers to this MP?
mpt
* What components might get impacted by your changes?
NetworkManager, Nuntium, Ofono
* Have you requested review by the teams of these owning components?
Yes
To post a comment you must log in.
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Needs Fixing
(continuous-integration)
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Approve
(continuous-integration)
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Needs Fixing
(continuous-integration)
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Approve
(continuous-integration)
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Approve
(continuous-integration)
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Approve
(continuous-integration)
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Needs Fixing
(continuous-integration)
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Needs Fixing
(continuous-integration)
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Approve
(continuous-integration)
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Approve
(continuous-integration)
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Needs Fixing
(continuous-integration)
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Approve
(continuous-integration)
Revision history for this message
| Jonas G. Drange (jonas-drange) wrote | # |
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Needs Fixing
(continuous-integration)
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Needs Fixing
(continuous-integration)
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Needs Fixing
(continuous-integration)
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Approve
(continuous-integration)
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Needs Fixing
(continuous-integration)
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Needs Fixing
(continuous-integration)
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Needs Fixing
(continuous-integration)
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
FAILED: Continuous integration, rev:1412
http://
Executed test runs:
UNSTABLE: http://
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://