Merge lp://staging/~jonas-drange/js-oopsd/conditional-setuptools-import into lp://staging/js-oopsd
Proposed by
Jonas G. Drange
| Status: | Needs review |
|---|---|
| Proposed branch: | lp://staging/~jonas-drange/js-oopsd/conditional-setuptools-import |
| Merge into: | lp://staging/js-oopsd |
| Diff against target: |
17 lines (+4/-2) 1 file modified
setup.py (+4/-2) |
| To merge this branch: | bzr merge lp://staging/~jonas-drange/js-oopsd/conditional-setuptools-import |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Ian Booth | Pending | ||
| Launchpad code reviewers | Pending | ||
|
Review via email:
|
|||
Commit message
consumers of js-oopsd can now use setuptools, if installed, to pull down dependencies listed in install_requires
Description of the change
Proposed fix
importing setuptools if it exists, keep using distutils if not
Pre-implementation notes
Since I have limited knowledge about python distribution I discussed this with a fellow developer and concluded that distutils emits warnings when encountering the install_requires list because it does not know what to do with it. setuptools do know how to deal with install_requires
Implementation
conditional import of setuptools in setup.py
To post a comment you must log in.
Unmerged revisions
- 14. By Jonas G. Drange
-
use setuptools if it exists to handle install_requires
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
