Merge lp://staging/~johannes-rudolph/do/space-backspace-navigation into lp://staging/do
Proposed by
Johannes Rudolph
| Status: | Rejected |
|---|---|
| Rejected by: | Alex Launi |
| Proposed branch: | lp://staging/~johannes-rudolph/do/space-backspace-navigation |
| Merge into: | lp://staging/do |
| To merge this branch: | bzr merge lp://staging/~johannes-rudolph/do/space-backspace-navigation |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| David Siegel (community) | Disapprove | ||
|
Review via email:
|
|||
To post a comment you must log in.
Revision history for this message
| Johannes Rudolph (johannes-rudolph) wrote | # |
Revision history for this message
| David Siegel (djsiegel-deactivatedaccount) wrote | # |
review:
Disapprove
Unmerged revisions
- 924. By Johannes Rudolph
-
merged to upstream
- 923. By Johannes Rudolph <email address hidden>
-
space navigation: make sure this is disabled while being in TextMode
- 922. By Johannes Rudolph <email address hidden>
-
introduced Item/Subitem navigation with space and backspace keys
* introduced preference option to use space/backspace
for navigation in addition to right/left
* added checkbox on KeyboardPreferences to set this behaviour
(couldn't add just binding options, since backspace has to be
handled specially, so that it works as left only when no chars
are left in the current context's query.)
This is a patch, which changes navigation between Items and their children to allow the Space/Backspace keys to be used.
I don't like navigating to children and back with the arrow keys. So, here is a patch which allows using space and backspace like they were Right and Left.
Backspace works only if the Query is empty, of course. And it doesn't apply for text mode. To enter text with spaces you must always enter text mode.
In the end it is a trade-off:
Wether you use Do often to enter text, then you may not like it having to enter the TextMode key all the time, or wether you often browse your music albums or similar then it is really cumbersome having to use the arrow keys all the time.