Ubuntu CI Dashboard

Merge lp://staging/~joetalbott/qa-dashboard/update_script_chdir into lp://staging/qa-dashboard

  1. update_script_chdir
  2. Merge into dev
Proposed by Joe Talbott
Status: Merged
Approved by: Chris Johnston
Approved revision: no longer in the source branch.
Merged at revision: 679
Proposed branch: lp://staging/~joetalbott/qa-dashboard/update_script_chdir
Merge into: lp://staging/qa-dashboard
Diff against target: 12 lines (+2/-0)
1 file modified
scripts/branch-update.py (+2/-0)
To merge this branch: bzr merge lp://staging/~joetalbott/qa-dashboard/update_script_chdir
Reviewer Review Type Date Requested Status
Chris Johnston Approve
Review via email: mp+194891@code.staging.launchpad.net

Commit message

branch update - Change into the repo directory before calling bzr.

Description of the change

branch update - Change into the repo directory before calling bzr.

To post a comment you must log in.
Revision history for this message
Chris Johnston (cjohnston) :
review: Approve
lp://staging/~joetalbott/qa-dashboard/update_script_chdir updated
679. By Joe Talbot <email address hidden>

[r=Chris Johnston] branch update - Change into the repo directory before calling bzr. from Joe Talbott

Revision history for this message
Andy Doan (doanac) wrote :

this is fine, but a nice trick that has less side-effects in your code would be to use the "cwd" parameter:

 if subprocess.call(['bzr', 'missing'], cwd=script_dir, stdout=FNULL):

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches