Merge into dev : drop_all_zero_errors : Code : Ubuntu CI Dashboard

Status:	Merged
Approved by:	Chris Johnston on 2013-01-03
Approved revision:	192
Merged at revision:	196
Proposed branch:	lp://staging/~joetalbott/qa-dashboard/drop_all_zero_errors
Merge into:	lp://staging/qa-dashboard
Diff against target:	112 lines (+51/-4) 2 files modified dashboard/utah_parser.py (+46/-3) dashboard/utah_utils.py (+5/-1)
To merge this branch:	bzr merge lp://staging/~joetalbott/qa-dashboard/drop_all_zero_errors
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Chris Johnston		2012-12-17	Approve on 2013-01-03
Review via email: mp+140285@code.staging.launchpad.net

Commit message

Don't error for default YAML logs with enough information to indicate client failure.

Description of the change

This branch adds a check method that will return true if 'errors', 'failures', and 'passes' are all present in the YAML log and are all zero. This makes ParserError include a flag that indicates the entry has enough to be treated as a failed run which prevents the error message indicating which fields are missing from being printed.

Revision history for this message

Chris Johnston (cjohnston) on 2013-01-03:

#

review: Approve

Revision history for this message

Chris Johnston (cjohnston) wrote on 2013-01-03:

#

The attempt to merge lp:~joetalbott/qa-dashboard/drop_all_zero_errors into lp:qa-dashboard failed. Below is the output from the failed tests.

Creating test database for alias 'default'...
Type 'yes' if you would like to try deleting the test database 'test_qa_dashboard', or 'no' to cancel:
Got an error creating the test database: database "test_qa_dashboard" already exists

Traceback (most recent call last):
  File "manage.py", line 26, in <module>
    execute_from_command_line(sys.argv)
  File "/usr/lib/python2.7/dist-packages/django/core/management/__init__.py", line 429, in execute_from_command_line
    utility.execute()
  File "/usr/lib/python2.7/dist-packages/django/core/management/__init__.py", line 379, in execute
    self.fetch_command(subcommand).run_from_argv(self.argv)
  File "/usr/lib/python2.7/dist-packages/django/core/management/base.py", line 191, in run_from_argv
    self.execute(*args, **options.__dict__)
  File "/usr/lib/python2.7/dist-packages/django/core/management/base.py", line 220, in execute
    output = self.handle(*args, **options)
  File "/usr/lib/python2.7/dist-packages/south/management/commands/test.py", line 8, in handle
    super(Command, self).handle(*args, **kwargs)
  File "/usr/lib/python2.7/dist-packages/django/core/management/commands/test.py", line 37, in handle
    failures = test_runner.run_tests(test_labels)
  File "/usr/lib/python2.7/dist-packages/django/test/simple.py", line 359, in run_tests
    old_config = self.setup_databases()
  File "/usr/lib/python2.7/dist-packages/django/test/simple.py", line 296, in setup_databases
    test_db_name = connection.creation.create_test_db(self.verbosity, autoclobber=not self.interactive)
  File "/usr/lib/python2.7/dist-packages/django/db/backends/creation.py", line 351, in create_test_db
    self._create_test_db(verbosity, autoclobber)
  File "/usr/lib/python2.7/dist-packages/django/db/backends/creation.py", line 431, in _create_test_db
    confirm = raw_input("Type 'yes' if you would like to try deleting the test database '%s', or 'no' to cancel: " % test_database_name)
EOFError: EOF when reading a line

The attempt to merge lp:~joetalbott/qa-dashboard/drop_all_zero_errors into lp:qa-dashboard failed. Below is the output from the failed tests.

Creating test database for alias 'default'...
Type 'yes' if you would like to try deleting the test database 'test_qa_dashboard', or 'no' to cancel: 
Got an error creating the test database: database "test_qa_dashboard" already exists

Traceback (most recent call last):
  File "manage.py", line 26, in <module>
    execute_from_command_line(sys.argv)
  File "/usr/lib/python2.7/dist-packages/django/core/management/__init__.py", line 429, in execute_from_command_line
    utility.execute()
  File "/usr/lib/python2.7/dist-packages/django/core/management/__init__.py", line 379, in execute
    self.fetch_command(subcommand).run_from_argv(self.argv)
  File "/usr/lib/python2.7/dist-packages/django/core/management/base.py", line 191, in run_from_argv
    self.execute(*args, **options.__dict__)
  File "/usr/lib/python2.7/dist-packages/django/core/management/base.py", line 220, in execute
    output = self.handle(*args, **options)
  File "/usr/lib/python2.7/dist-packages/south/management/commands/test.py", line 8, in handle
    super(Command, self).handle(*args, **kwargs)
  File "/usr/lib/python2.7/dist-packages/django/core/management/commands/test.py", line 37, in handle
    failures = test_runner.run_tests(test_labels)
  File "/usr/lib/python2.7/dist-packages/django/test/simple.py", line 359, in run_tests
    old_config = self.setup_databases()
  File "/usr/lib/python2.7/dist-packages/django/test/simple.py", line 296, in setup_databases
    test_db_name = connection.creation.create_test_db(self.verbosity, autoclobber=not self.interactive)
  File "/usr/lib/python2.7/dist-packages/django/db/backends/creation.py", line 351, in create_test_db
    self._create_test_db(verbosity, autoclobber)
  File "/usr/lib/python2.7/dist-packages/django/db/backends/creation.py", line 431, in _create_test_db
    confirm = raw_input("Type 'yes' if you would like to try deleting the test database '%s', or 'no' to cancel: " % test_database_name)
EOFError: EOF when reading a line

Ubuntu CI Dashboard

Merge lp://staging/~joetalbott/qa-dashboard/drop_all_zero_errors into lp://staging/qa-dashboard

Commit message

Description of the change

Preview Diff

Subscribers