Merge lp://staging/~joetalbott/qa-dashboard/add_xorg_desktop_column into lp://staging/qa-dashboard

Proposed by Joe Talbott
Status: Merged
Approved by: Chris Johnston
Approved revision: 193
Merged at revision: 192
Proposed branch: lp://staging/~joetalbott/qa-dashboard/add_xorg_desktop_column
Merge into: lp://staging/qa-dashboard
Diff against target: 228 lines (+155/-4)
2 files modified
bootspeed/migrations/0004_auto__add_field_imagemachineagg_xorg_plumbing_min__add_field_imagemach.py (+128/-0)
bootspeed/models.py (+27/-4)
To merge this branch: bzr merge lp://staging/~joetalbott/qa-dashboard/add_xorg_desktop_column
Reviewer Review Type Date Requested Status
Chris Johnston Approve
Review via email: mp+140309@code.staging.launchpad.net

Commit message

Add xorg_plumbing column to aggregations.

Description of the change

Add xorg_plumbing column to aggregations.

To post a comment you must log in.
Revision history for this message
Chris Johnston (cjohnston) wrote :

The only issue I possibly see is that we are only doing xorg+plumbing on ImageMachineAgg... This makes it to where we can't display this on the raw data chart. If needed, we *could* do the math on the fly, though as we have found out in the past that isn't a very good way of doing things. Or people could just do the addition in their head? Or we could add it to ImageResult.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches