Merge lp://staging/~joetalbott/core-image-builder/add_build_logic into lp://staging/core-image-builder

Proposed by Joe Talbott
Status: Merged
Approved by: Joe Talbott
Approved revision: 5
Merged at revision: 3
Proposed branch: lp://staging/~joetalbott/core-image-builder/add_build_logic
Merge into: lp://staging/core-image-builder
Diff against target: 304 lines (+169/-37)
5 files modified
core_image_builder/__init__.py (+3/-3)
core_image_builder/queue.py (+2/-2)
core_image_builder/worker.py (+151/-32)
requirements.txt (+11/-0)
test_requirements.txt (+2/-0)
To merge this branch: bzr merge lp://staging/~joetalbott/core-image-builder/add_build_logic
Reviewer Review Type Date Requested Status
Joe Talbott (community) Approve
Francis Ginther Approve
Review via email: mp+259834@code.staging.launchpad.net

Commit message

Add first pass at image building logic.

Description of the change

Add first pass at image building logic.

To post a comment you must log in.
Revision history for this message
Para Siva (psivaa) wrote :

Could not find any issues except a question inline.

Revision history for this message
Francis Ginther (fginther) wrote :

I've logged several comments, but nothing that should block this current MP. In fact, I would feel better landing this and then iterating on the comments in other MPs.

Also, it is my opinion that the channel and release input needs to come from the core-tester-agent. This is to solve the problem of needing to test both vivid and wily packages that land into two different core channels. Perhaps there is another solution that I've overlooked.

review: Approve
Revision history for this message
Ubuntu CI Bot (uci-bot) wrote :
Download full text (24.0 KiB)

The attempt to merge lp:~joetalbott/core-image-builder/add_build_logic into lp:core-image-builder failed. Below is the output from the failed tests.

Using base prefix '/usr'
New python executable in /tmp/venv-core-image-builder7hpvuyab/bin/python3
Also creating executable in /tmp/venv-core-image-builder7hpvuyab/bin/python
Installing setuptools, pip...done.
Running virtualenv with interpreter /usr/bin/python3
Ignoring indexes: https://pypi.python.org/simple/
Downloading/unpacking cffi (from -r requirements.txt (line 5))
  Running setup.py (path:/tmp/venv-core-image-builder7hpvuyab/build/cffi/setup.py) egg_info for package cffi

Downloading/unpacking pyasn1 (from -r requirements.txt (line 6))
  Running setup.py (path:/tmp/venv-core-image-builder7hpvuyab/build/pyasn1/setup.py) egg_info for package pyasn1

Downloading/unpacking kombu==3.0.24 (from -r requirements.txt (line 7))
Downloading/unpacking python-logstash==0.4.2 (from -r requirements.txt (line 8))
  Running setup.py (path:/tmp/venv-core-image-builder7hpvuyab/build/python-logstash/setup.py) egg_info for package python-logstash

Downloading/unpacking python-glanceclient==0.17.0 (from -r requirements.txt (line 9))
Downloading/unpacking uservice-utils==1.0.3 (from -r requirements.txt (line 10))
Downloading/unpacking traceback2==1.4.0 (from -r requirements.txt (line 11))
Downloading/unpacking pycparser (from cffi->-r requirements.txt (line 5))
  Running setup.py (path:/tmp/venv-core-image-builder7hpvuyab/build/pycparser/setup.py) egg_info for package pycparser

    warning: no previously-included files matching 'yacctab.*' found under directory 'tests'
    warning: no previously-included files matching 'lextab.*' found under directory 'tests'
    warning: no previously-included files matching 'yacctab.*' found under directory 'examples'
    warning: no previously-included files matching 'lextab.*' found under directory 'examples'
Downloading/unpacking anyjson>=0.3.3 (from kombu==3.0.24->-r requirements.txt (line 7))
  Running setup.py (path:/tmp/venv-core-image-builder7hpvuyab/build/anyjson/setup.py) egg_info for package anyjson

Downloading/unpacking amqp>=1.4.5,<2.0 (from kombu==3.0.24->-r requirements.txt (line 7))
  Running setup.py (path:/tmp/venv-core-image-builder7hpvuyab/build/amqp/setup.py) egg_info for package amqp

Downloading/unpacking argparse (from python-glanceclient==0.17.0->-r requirements.txt (line 9))
Downloading/unpacking python-keystoneclient>=1.0.0 (from python-glanceclient==0.17.0->-r requirements.txt (line 9))
Downloading/unpacking warlock>=1.0.1,<2 (from python-glanceclient==0.17.0->-r requirements.txt (line 9))
  Running setup.py (path:/tmp/venv-core-image-builder7hpvuyab/build/warlock/setup.py) egg_info for package warlock

Downloading/unpacking Babel>=1.3 (from python-glanceclient==0.17.0->-r requirements.txt (line 9))
  Running setup.py (path:/tmp/venv-core-image-builder7hpvuyab/build/Babel/setup.py) egg_info for package Babel

    warning: no previously-included files matching '*' found under directory 'docs/_build'
    warning: no previously-included files matching '*.pyc' found under directory 'tests'
    warning: no previously-...

5. By Joe Talbott

Fix flake8 warning

Revision history for this message
Joe Talbott (joetalbott) wrote :

One more commit to fix a silly flake8 warning. I'm self-approving since it's so minor.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches