Merge lp://staging/~joetalbott/ci-core-jenkins/fix_names into lp://staging/ci-core-jenkins

Proposed by Joe Talbott
Status: Merged
Approved by: Joe Talbott
Approved revision: 17
Merged at revision: 16
Proposed branch: lp://staging/~joetalbott/ci-core-jenkins/fix_names
Merge into: lp://staging/ci-core-jenkins
Diff against target: 34 lines (+9/-8)
1 file modified
workers/fetch_latest_results/__init__.py (+9/-8)
To merge this branch: bzr merge lp://staging/~joetalbott/ci-core-jenkins/fix_names
Reviewer Review Type Date Requested Status
Francis Ginther Approve
Para Siva (community) Approve
Review via email: mp+262636@code.staging.launchpad.net

Commit message

Make container and result file names match what lp:autopkgtest-result-checker produces.

Description of the change

Make container and result file names match what lp:autopkgtest-result-checker produces.

To post a comment you must log in.
Revision history for this message
Para Siva (psivaa) wrote :

Seems ok to me, not being able to test this though.

review: Approve
Revision history for this message
Para Siva (psivaa) wrote :

This also needs the AUTH url change in the config file. I already had an MP for this in-progress for the channel, release name fixes to land. https://code.launchpad.net/~psivaa/ci-core-jenkins/ps4.5-auth-url/+merge/261357

Revision history for this message
Francis Ginther (fginther) wrote :

Argh, I missed this in my earlier review, there is no "args.release" being parsed. I'm not opposed to setting this with a default value of "rolling" and limiting the amount of code changes.

review: Needs Fixing
17. By Joe Talbott

Hardcode "rolling" for the release for now.

Revision history for this message
Francis Ginther (fginther) wrote :

should be good to go, thanks

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches