ci-core-jenkins

Merge lp://staging/~joetalbott/ci-core-jenkins/fix_arch_jobname into lp://staging/ci-core-jenkins

  1. fix_arch_jobname
  2. Merge into trunk
Proposed by Joe Talbott
Status: Merged
Approved by: Para Siva
Approved revision: 12
Merged at revision: 9
Proposed branch: lp://staging/~joetalbott/ci-core-jenkins/fix_arch_jobname
Merge into: lp://staging/ci-core-jenkins
Diff against target: 23 lines (+6/-7)
1 file modified
jenkins/setup-jobs.py (+6/-7)
To merge this branch: bzr merge lp://staging/~joetalbott/ci-core-jenkins/fix_arch_jobname
Reviewer Review Type Date Requested Status
Para Siva (community) Approve
Review via email: mp+255727@code.staging.launchpad.net

Commit message

Fix device_type to not include '-' or '_'.

Description of the change

Fix device_type to not include '-' or '_'.

To post a comment you must log in.
lp://staging/~joetalbott/ci-core-jenkins/fix_arch_jobname updated
10. By Joe Talbott

Add missing 'core' to the jobname.

Revision history for this message
Para Siva (psivaa) wrote :

Commented inline.
So basically the job names are going to contain ':' ?
I haven't seen any such jobs, but not saying its wrong.

review: Needs Fixing
Revision history for this message
Joe Talbott (joetalbott) wrote :

Yeah, We're trying that since we can't use '-' or '_' in the arch field.

lp://staging/~joetalbott/ci-core-jenkins/fix_arch_jobname updated
11. By Joe Talbott

It seems ':' is not allowed in jenkins job names.

12. By Joe Talbott

call str.join() with iterables and replace '_' in the proper 'device_type' variable.

Revision history for this message
Para Siva (psivaa) wrote :

Thanks. +1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches