Account - Financial Tools

Merge lp://staging/~joaquing-pedrosa/account-financial-tools/7.0-account_invoice_currency into lp://staging/~account-core-editors/account-financial-tools/7.0

  1. 7.0-account_invoice_currency
  2. Merge into 7.0
Proposed by Joaquin Gutierrez
Status: Merged
Merged at revision: 152
Proposed branch: lp://staging/~joaquing-pedrosa/account-financial-tools/7.0-account_invoice_currency
Merge into: lp://staging/~account-core-editors/account-financial-tools/7.0
Diff against target: 602 lines (+561/-0)
8 files modified
account_invoice_currency/__init__.py (+22/-0)
account_invoice_currency/__openerp__.py (+47/-0)
account_invoice_currency/account_invoice_view.xml (+44/-0)
account_invoice_currency/i18n/account_invoice_currency.pot (+57/-0)
account_invoice_currency/i18n/ca.po (+83/-0)
account_invoice_currency/i18n/es.po (+76/-0)
account_invoice_currency/i18n/pt.po (+84/-0)
account_invoice_currency/invoice.py (+148/-0)
To merge this branch: bzr merge lp://staging/~joaquing-pedrosa/account-financial-tools/7.0-account_invoice_currency
Reviewer Review Type Date Requested Status
Pedro Manuel Baeza Approve
Review via email: mp+199967@code.staging.launchpad.net

Commit message

Migration module to version 7 and add the same to the branch account_financial_tools

Description of the change

[FIX]: Update view definitions to version 7.0.
[FIX]: Changed types to orm.Model, orm.TransientModel and orm.AbstractModel.
[FIX]: Remove 'init_xml' keys, because it's no longer needed in v7.
[FIX]: Remove __author__ variables in files, because authors are put on manifest file (__openerp__.py).
[FIX]: Imports in standard format.
[FIX]: Format the text that explains the module.
[FIX]: Increased compatibility with standard PEP8.

To post a comment you must log in.
Revision history for this message
Pedro Manuel Baeza (pedro.baeza) wrote :

Hi, Joaquin,

Please remove class instantiation at the end of invoice.py, but the rest is OK.

Regards.

review: Needs Fixing (code review)
lp://staging/~joaquing-pedrosa/account-financial-tools/7.0-account_invoice_currency updated
137. By Joaquin Gutierrez

[FIX] Remove class instantiation at the end of invoice.py

Revision history for this message
Joaquin Gutierrez (joaquing-pedrosa) wrote :

Hi, Pedro:

I've fixed the code

Regards.

Revision history for this message
Pedro Manuel Baeza (pedro.baeza) wrote :

Thanks!

review: Approve
Revision history for this message
Pedro Manuel Baeza (pedro.baeza) wrote :

I proceed with the merge, although there is only my approval, because the commiter and I have tested it during this month, and we need this module merged for the spanish localization.

Regards.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches