Account - Financial Tools

Merge lp://staging/~joaquing-pedrosa/account-financial-tools/7.0-account-chart-update into lp://staging/~account-core-editors/account-financial-tools/7.0

  1. 7.0-account-chart-update
  2. Merge into 7.0
Proposed by Joaquin Gutierrez
Status: Merged
Merged at revision: 123
Proposed branch: lp://staging/~joaquing-pedrosa/account-financial-tools/7.0-account-chart-update
Merge into: lp://staging/~account-core-editors/account-financial-tools/7.0
Diff against target: 7370 lines (+7303/-0)
13 files modified
account_chart_update/__init__.py (+25/-0)
account_chart_update/__openerp__.py (+71/-0)
account_chart_update/i18n/account_chart_update.pot (+749/-0)
account_chart_update/i18n/ca.po (+835/-0)
account_chart_update/i18n/ca_ES.po (+323/-0)
account_chart_update/i18n/es.po (+707/-0)
account_chart_update/i18n/es_ES.po (+807/-0)
account_chart_update/i18n/fr.po (+767/-0)
account_chart_update/i18n/pt.po (+844/-0)
account_chart_update/i18n/sv.po (+765/-0)
account_chart_update/wizard/__init__.py (+25/-0)
account_chart_update/wizard/wizard_chart_update.py (+1212/-0)
account_chart_update/wizard/wizard_chart_update_view.xml (+173/-0)
To merge this branch: bzr merge lp://staging/~joaquing-pedrosa/account-financial-tools/7.0-account-chart-update
Reviewer Review Type Date Requested Status
Pedro Manuel Baeza code review and test Approve
Review via email: mp+188649@code.staging.launchpad.net

Commit message

[MRG]: Port account_char_update to version 7.0

Description of the change

[MRG]: Port account_char_update to version 7.0
[FIX]: Changed types to orm.Model, orm.TransientModel and orm.AbstractModel.
[FIX]: Fix deletion method for some fields of objects.
[FIX]: Contributions have been written in the standard format of the community.
[FIX]: Changes in the form to work as a real wizard.
[FIX]: Remove 'init_xml' keys, because it's no longer needed in v7.
[FIX]: Rename 'demo_xml' key to the new standard 'demo'.
[FIX]: Change imports calls.
[FIX]: Remove __author__ variables in files, because authors are put on manifest file (__openerp__.py).
[FIX]: Update view definitions to version 7.0
[FIX]: Rename variables to OpenERP standard.
[FIX]: Increased compatibility with standard PEP8.

To post a comment you must log in.
Revision history for this message
Pedro Manuel Baeza (pedro.baeza) wrote :

Hi, Joaquin, user invitu has made another MP migrating this same module. He says that he has added french translation and a small refactorisation to keep the wizard opened. Could you please see these improvements and merge with yours, crediting him properly?

https://code.launchpad.net/~invitu/account-financial-tools/add_account_chart_update_module_for_v70/+merge/189734

Thank you.

Revision history for this message
Joaquin Gutierrez (joaquing-pedrosa) wrote :

Hello Pedro:

Ok, I will add the improvements proposed by Invitu and update el code.

Thank all for the work.

lp://staging/~joaquing-pedrosa/account-financial-tools/7.0-account-chart-update updated
125. By Joaquin Gutierrez

[IMP]: User Invitu add the method call _reopen to keep open the wizard.
[MRG]: User Invitu add frech language.

Revision history for this message
Pedro Manuel Baeza (pedro.baeza) wrote :

Hi, Joaquin, thank you for all your work, and sorry for the late review, but I have been very busy and I want to test this module deeply.

In general terms, it works like a charm, but there are some minor fine-tuning that I have made in a branch to MP to yours. You can see changes on commit message.

Regards.

Revision history for this message
Joaquin Gutierrez (joaquing-pedrosa) wrote :

Hi Pedro:

Thanks for your work of review, the important thing is that the module is
perfect. Time is not important. 'll Check your changes to understand your
improvements to the code and the next time I could do it.

Thank

2013/10/15 Pedro Manuel Baeza <email address hidden>

> Hi, Joaquin, thank you for all your work, and sorry for the late review,
> but I have been very busy and I want to test this module deeply.
>
> In general terms, it works like a charm, but there are some minor
> fine-tuning that I have made in a branch to MP to yours. You can see
> changes on commit message.
>
> Regards.
>
> --
>
> https://code.launchpad.net/~joaquing-pedrosa/account-financial-tools/7.0-account-chart-update/+merge/188649
> You are the owner of
> lp:~joaquing-pedrosa/account-financial-tools/7.0-account-chart-update.
>

lp://staging/~joaquing-pedrosa/account-financial-tools/7.0-account-chart-update updated
126. By Joaquin Gutierrez

Multiple changes by Pedro Manuel Baeza
[FIX] account_chart_update: Corrected description for RST parser and english faults in it.
[FIX] account_chart_update: Corrected some english terms.
[IMP] account_chart_update: Changed name of menu to avoid excessive length.
[IMP] account_chart_update: Removed three line comments style.
[IMP] account_chart_update: Remove class instantiation.
[IMP] account_chart_update: Put method descriptions according documentation standards.
[IMP] account_chart_update: Updated translations.
[IMP] account_chart_update: Menu path to avoid needing multi-company permission.

Revision history for this message
Pedro Manuel Baeza (pedro.baeza) wrote :

Very good, Joaquín!

Thank you.

review: Approve (code review and test)
Revision history for this message
Pedro Manuel Baeza (pedro.baeza) wrote :

Joaquín, invitu has made a MP to your branch to complete the module. Can you check it?

Thanks.

lp://staging/~joaquing-pedrosa/account-financial-tools/7.0-account-chart-update updated
127. By Joaquin Gutierrez

Invitu 2013-10-18 [IMP] small improvement : calling reopen method in action_init + indentation

Revision history for this message
Pedro Manuel Baeza (pedro.baeza) wrote :

If nobody review also this MP, I will proceed tomorrow to make the merge, because I have extensively tested and seems OK technical and funcional speaking.

Regards.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches