Merge lp://staging/~jml/pkgme/split-write-packaging into lp://staging/pkgme
Proposed by
Jonathan Lange
Status: | Merged |
---|---|
Approved by: | Jonathan Lange |
Approved revision: | 143 |
Merged at revision: | 136 |
Proposed branch: | lp://staging/~jml/pkgme/split-write-packaging |
Merge into: | lp://staging/pkgme |
Diff against target: |
222 lines (+110/-25) 4 files modified
buildout.cfg (+1/-0) pkgme/__init__.py (+32/-3) pkgme/tests/test_write_packaging.py (+75/-21) versions.cfg (+2/-1) |
To merge this branch: | bzr merge lp://staging/~jml/pkgme/split-write-packaging |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
James Westby | Approve | ||
Review via email: mp+121666@code.staging.launchpad.net |
Commit message
Split write_packaging so that there's a way to get information.
Description of the change
Reasonably simple thing to let pkgme-service get the info that pkgme finds.
It just blows up ``write_packaging`` into its constituent parts. I considered making ``write_packaging`` return info. I didn't. I don't know why.
Switched to use treeshape to make the tests a bit more declarative.
get_packaging_info really ought to include the want reasons & scores from rejected backends, but I think that ought to be a simple change.
Thanks,
jml
To post a comment you must log in.
67 + # Do these imports in the function to reduce the side-effects of importing
68 + # pkgme. This avoids the need for setup.py of the tool being packaged
69 + # from having to find all the imported dependencies when running the
70 + # extension pkgme_info setup.py command.
There's no imports in that function. Maybe it was supposed to be in the previous function?
Thanks,
James