Merge lp://staging/~jml/pkgme/missing-lsb-release into lp://staging/pkgme
Proposed by
Jonathan Lange
| Status: | Merged |
|---|---|
| Approved by: | James Westby |
| Approved revision: | 148 |
| Merged at revision: | 147 |
| Proposed branch: | lp://staging/~jml/pkgme/missing-lsb-release |
| Merge into: | lp://staging/pkgme |
| Diff against target: |
97 lines (+41/-6) 3 files modified
NEWS.txt (+9/-0) pkgme/info_elements.py (+12/-4) pkgme/tests/test_info_elements.py (+20/-2) |
| To merge this branch: | bzr merge lp://staging/~jml/pkgme/missing-lsb-release |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| James Westby | Approve | ||
|
Review via email:
|
|||
Commit message
Handle missing lsb-release
Description of the change
Applies Natalia's patch from bug 1010411.
Changes Distribution to default to UNRELEASED if there's no lsb-release,
rather than just erroring out.
I've updated the patch to use try/except for the main logic, and to have
a test for missing lsb-release, by adding another (bad) layer of abstraction.
Obviously the correct thing to do is to have a full filesystem abstraction.
Thanks,
jml
To post a comment you must log in.
Revision history for this message
| James Westby (james-w) | # |
review:
Approve
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
