Merge lp://staging/~jml/launchpad/poppy-cleanup into lp://staging/launchpad
Proposed by
Jonathan Lange
| Status: | Merged |
|---|---|
| Approved by: | Brad Crittenden |
| Approved revision: | no longer in the source branch. |
| Merged at revision: | 11071 |
| Proposed branch: | lp://staging/~jml/launchpad/poppy-cleanup |
| Merge into: | lp://staging/launchpad |
| Diff against target: |
270 lines (+155/-26) 4 files modified
daemons/poppy-sftp.tac (+4/-0) lib/lp/codehosting/sshserver/session.py (+3/-25) lib/lp/services/sshserver/session.py (+43/-1) lib/lp/services/sshserver/tests/test_session.py (+105/-0) |
| To merge this branch: | bzr merge lp://staging/~jml/launchpad/poppy-cleanup |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Brad Crittenden (community) | code | Approve | |
|
Review via email:
|
|||
Description of the change
This branch fixes bug 598532 and a related, unreported bug about poppy giving an ugly error when you try to execute a command on the server (e.g. "ssh ppa.launchpad.net ls")
It does so by providing a "session" adapter for poppy that provides no services itself. The session adapter is a user's view of the SSH server (minus any apps like sftp). For poppy, we don't want shells, terminals or executed processes, so a "do nothing" adapter is the right fit.
The code was written by stealing the relevant bits from the codehosting session adapter, which does pratically nothing.
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Nice branch Jono