wicd

Merge lp://staging/~jmacmahon/wicd/wired-enc into lp://staging/wicd/1.6

wired-enc
Merge into experimental

Proposed by Joe MacMahon on 2012-01-29

Status:

Merged

Merged at revision:

716

Proposed branch:

lp://staging/~jmacmahon/wicd/wired-enc

Merge into:

lp://staging/wicd/1.6

Diff against target:

631 lines (+289/-110)

9 files modified

curses/netentry_curses.py (+114/-47)
curses/wicd-curses.py (+1/-1)
encryption/templates/active_wired (+1/-0)
encryption/templates/wired_8021x (+17/-0)
gtk/netentry.py (+110/-42)
wicd/misc.py (+15/-5)
wicd/networking.py (+15/-7)
wicd/wicd-daemon.py (+2/-1)
wicd/wnettools.py (+14/-7)

To merge this branch:

bzr merge lp://staging/~jmacmahon/wicd/wired-enc

Medium

Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
David Paleino		2012-01-29	Approve on 2012-02-02
Review via email: mp+90615@code.staging.launchpad.net

Description of the change

Wired encryption templates have been implemented in the daemon, GTK interface and ncurses interface.

Included is an encryption template for 802.1x wired networks.

Encryption settings may be saved to and loaded from wired profiles.

lp://staging/~jmacmahon/wicd/wired-enc updated on 2012-01-31

712. By David Paleino on 2012-01-31: Finally really fix the issue with \x00-ESSIDs :(

Revision history for this message

David Paleino (dpaleino) wrote on 2012-01-31:

Oh, thanks.

I don't have any kind of such setup handy, so I can't really test it. I'm confident you did, though :)

I'll review the code ASAP.

Thanks for your contribution,
David

lp://staging/~jmacmahon/wicd/wired-enc updated on 2012-02-01

713. By Launchpad Translations on behalf of wicd-devel on 2012-02-01: Launchpad automatic translations update.

Revision history for this message

Joe MacMahon (jmacmahon) wrote on 2012-02-01:

Yes it works perfectly with the setup I have in university halls,
however I'm not overly confident all 802.1x setups are the same, so a
new template may be required when such an issue becomes apparent.

Regardless, the framework is now in place in the code to support such
templates.

Thanks very much,
Joe

On 31/01/12 17:28, David Paleino wrote:
> Oh, thanks.
>
> I don't have any kind of such setup handy, so I can't really test it. I'm confident you did, though :)
>
> I'll review the code ASAP.
>
> Thanks for your contribution,
> David

lp://staging/~jmacmahon/wicd/wired-enc updated on 2012-02-02

714. By David Paleino on 2012-02-01: Try to better handle the double-escaped unicode ESSIDs
715. By Launchpad Translations on behalf of wicd-devel on 2012-02-02: Launchpad automatic translations update.
716. By David Paleino on 2012-02-02: Merged wired-encryption implementation by Joe MacMahon. Thanks!