RescueTime Linux Uploader

Merge lp://staging/~jlisee/rescuetime-linux-uploader/experimental into lp://staging/rescuetime-linux-uploader

experimental
Merge into trunk

Proposed by Dirk T on 2012-08-14

Status:

Merged

Merged at revision:

105

Proposed branch:

lp://staging/~jlisee/rescuetime-linux-uploader/experimental

Merge into:

lp://staging/rescuetime-linux-uploader

Diff against target:

335 lines (+226/-4)

5 files modified

RescueTimeUploader/extensions/Gnome-terminal/app_name (+5/-0)
RescueTimeUploader/extensions/Google-chrome/extended_info (+136/-0)
RescueTimeUploader/uploader.py (+16/-4)
chrome_extension/background.html (+55/-0)
chrome_extension/manifest.json (+14/-0)

To merge this branch:

bzr merge lp://staging/~jlisee/rescuetime-linux-uploader/experimental

Related bugs:

Bug #606956: Google Chrome support

Low

In Progress

Link a bug report

Reviewer	Review Type	Date Requested	Status
Joseph Lisee (community)			Approve on 2012-08-14
Dirk T			Needs Information on 2012-08-14
Review via email: mp+119601@code.staging.launchpad.net

Revision history for this message

Dirk T (miriup) wrote on 2012-08-14:

Joseph, not sure if you're still active in this project. Do you remember what made you create revision 105?

review: Needs Information

Revision history for this message

Joseph Lisee (jlisee) wrote on 2012-08-14:

> Joseph, not sure if you're still active in this project. Do you remember what
> made you create revision 105?

I am pretty sure I found a race condition between two threads. Even through threading isn't used explicitly with the way things are done the Uploader class runs in a different thread then whatever runs the gnome panel.

Revision history for this message

Joseph Lisee (jlisee) wrote on 2012-08-14:

I approve of the merge. My only reservation is that I have not used the Chrome plugin in a while so I am not sure if it still works. Even if it doesn't I think it would only require minor updates to get it working again.

review: Approve

Revision history for this message

Dirk T (miriup) wrote on 2012-08-14:

> I approve of the merge. My only reservation is that I have not used the Chrome
> plugin in a while so I am not sure if it still works.

I will know. I'm using as my primary browser. :)

Cheers,
Dirk.