txFluidDB

Merge lp://staging/~jkakar/txfluiddb/get-object-tags into lp://staging/txfluiddb

  1. get-object-tags
  2. Merge into trunk
Proposed by Jamu Kakar
Status: Merged
Approved by: Tristan Seligmann
Approved revision: 10
Merged at revision: 11
Proposed branch: lp://staging/~jkakar/txfluiddb/get-object-tags
Merge into: lp://staging/txfluiddb
Diff against target: 39 lines (+6/-7)
2 files modified
txfluiddb/client.py (+3/-4)
txfluiddb/test/test_client.py (+3/-3)
To merge this branch: bzr merge lp://staging/~jkakar/txfluiddb/get-object-tags
Reviewer Review Type Date Requested Status
Tristan Seligmann Approve
Review via email: mp+27430@code.staging.launchpad.net

Description of the change

This branch introduces the following changes:

- The request made when Object.getTags is invoked passes
  showAbout=True in the query string, because the request is a GET,
  instead of attempting to send it as POST data.

- There are 3 failing tests that are not fixed: they fail in trunk,
  too.

To post a comment you must log in.
Revision history for this message
Tristan Seligmann (mithrandi) wrote :

I think the test should assert that there is no content body being sent with the request at all; ie. endpoint.data is None. Perhaps the tests should be extended to assert this for any GET request? That's probably beyond the scope of this branch, though.

review: Needs Fixing
Revision history for this message
Jamu Kakar (jkakar) wrote :

Good call. I've added a check to MockEndpoint to raise an exception
if the method is GET and postdata is not None.

lp://staging/~jkakar/txfluiddb/get-object-tags updated
10. By Jamu Kakar

- MockEndpoint raises a RuntimeError if postdata is included with a
  GET request.

Revision history for this message
Tristan Seligmann (mithrandi) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: