Merge lp://staging/~jkakar/txfluiddb/endpoint-trailing-slash into lp://staging/txfluiddb
Proposed by
Jamu Kakar
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Approved by: | Tristan Seligmann | ||||
| Approved revision: | 12 | ||||
| Merged at revision: | 12 | ||||
| Proposed branch: | lp://staging/~jkakar/txfluiddb/endpoint-trailing-slash | ||||
| Merge into: | lp://staging/txfluiddb | ||||
| Diff against target: |
33 lines (+12/-0) 2 files modified
txfluiddb/client.py (+2/-0) txfluiddb/test/test_client.py (+10/-0) |
||||
| To merge this branch: | bzr merge lp://staging/~jkakar/txfluiddb/endpoint-trailing-slash | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Tristan Seligmann | Approve | ||
|
Review via email:
|
|||
Description of the change
This branch introduces the following changes:
- A trailing slash is automatically appended to a base URL that
doesn't have one when an Endpoint is instantiated.
To post a comment you must log in.
Revision history for this message
| Terry Jones (terrycojones) wrote | # |
Revision history for this message
| Tristan Seligmann (mithrandi) | # |
review:
Approve
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Looks fine to me. I'm of course not sure if Tristan will want this change. I also hit this problem once.