Merge lp://staging/~jkakar/todo/project-skeleton into lp://staging/todo

Proposed by Jamu Kakar
Status: Needs review
Proposed branch: lp://staging/~jkakar/todo/project-skeleton
Merge into: lp://staging/todo
Diff against target: 422 lines (+381/-0)
8 files modified
.bzrignore (+1/-0)
Makefile (+29/-0)
README.rst (+227/-0)
TODO (+7/-0)
bin/td (+14/-0)
setup.py (+42/-0)
todo/__init__.py (+18/-0)
todo/entry_point.py (+43/-0)
To merge this branch: bzr merge lp://staging/~jkakar/todo/project-skeleton
Reviewer Review Type Date Requested Status
Nicholas Tollervey Needs Fixing
Review via email: mp+46898@code.staging.launchpad.net

Description of the change

This branch introduces the following changes:

- A README.rst file has been added with ideas about the command line
  UI sketched out. There is still more to describe, but we have
  enough of a basic design to start writing some code.

- A Makefile and setup.py are in place with basic support for running
  tests, generating API documentation, etc.

- A mostly empty top-level 'todo' package has been added. It has an
  'entry_point' module with glue to wire up Commandant. A bin/td
  executable invokes entery point code. At present it just displays
  the stock 'basic' help topic and the stock builtin 'help' and
  'version' commands.

To post a comment you must log in.
Revision history for this message
Nicholas Tollervey (ntoll) wrote :

OK... The only reason I put that it needs fixing is because of the following relatively trivial items:

1) Please list authors alphabetically - it's a nice precedent that everyone understands.
2) The setup.py file needs to reference commandant in some way. The simplest thing to do would be to upload commandant to PyPI and add the following line in setup.py:

     requires=['commandant',]

Instructions for how to do this can be found in the Python docs. I'm more than happy to help with this process (it's very easy).

Other than that +10000000 from me. :-)

review: Needs Fixing
9. By Jamu Kakar

- Reorder authors to be alphabetic.

10. By Jamu Kakar

- Added 'commandant' to the requires list in setup.py.

Revision history for this message
Jamu Kakar (jkakar) wrote :

I've pushed new revisions with the fixes you've requested. Thanks for
the review!

Unmerged revisions

10. By Jamu Kakar

- Added 'commandant' to the requires list in setup.py.

9. By Jamu Kakar

- Reorder authors to be alphabetic.

8. By Jamu Kakar

- Added information about dependencies to the README file.

7. By Jamu Kakar

- Added a Makefile with basic targets to run tests, generate API
  documentation, etc.
- Added a setup.py to generate releases.
- Added _trial_temp to Bazaar's ignore list.

6. By Jamu Kakar

- Added a bin/td executable to invoke Todo.

5. By Jamu Kakar

- Added a 'todo' package with a simple entry point to wire up
  Commandant.

4. By Jamu Kakar

- Added a 'License' section.

3. By Jamu Kakar

- Added more details to the README and TODO files.

2. By Jamu Kakar

- Start writing README and TODO files to design the user interface and
  capture questions.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: