Storm

Merge lp://staging/~jkakar/storm/uuid-bug-fixes into lp://staging/storm

  1. uuid-bug-fixes
  2. Merge into trunk
Proposed by Jamu Kakar
Status: Merged
Approved by: Thomas Herve
Approved revision: 388
Merged at revision: 393
Proposed branch: lp://staging/~jkakar/storm/uuid-bug-fixes
Merge into: lp://staging/storm
Diff against target: 120 lines (+25/-5)
6 files modified
storm/locals.py (+1/-1)
storm/variables.py (+1/-1)
tests/store/base.py (+14/-2)
tests/store/mysql.py (+5/-1)
tests/store/postgres.py (+2/-0)
tests/store/sqlite.py (+2/-0)
To merge this branch: bzr merge lp://staging/~jkakar/storm/uuid-bug-fixes
Reviewer Review Type Date Requested Status
Thomas Herve (community) Approve
James Henstridge Approve
Review via email: mp+49616@code.staging.launchpad.net

Description of the change

This branch introduces the following changes:

- UUIDVariable.parse_get now returns a unicode value, instead of a str
  value, which makes it work with psycopg.

To post a comment you must log in.
Revision history for this message
James Henstridge (jamesh) wrote :

Looks good, although I don't see what the tests/databases/postgres.py changes are needed for. The testing seems to be happening at the tests/store level.

review: Approve
Revision history for this message
Jamu Kakar (jkakar) wrote :

James:

Thanks for the review. I must have accidentally committed those
changes to tests/databases/postgres.py... I've removed them now.

lp://staging/~jkakar/storm/uuid-bug-fixes updated
388. By Jamu Kakar

- Reverted unnecessary changes.

Revision history for this message
Thomas Herve (therve) wrote :

[1] If possible, it would be nice to reuse the table "foo" instead of creating another table which is only used in one test.

+1!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: