Code review comment for lp://staging/~jkakar/storm/resultselect

Revision history for this message
James Henstridge (jamesh) wrote :

I was happy with the previous interface to be honest, so I'm marking this abstain: Gustavo is the one to convince here.

I will note that this could just as easily be a factory function producing a Select instead of a new class. That would also remove the possibility of not transcribing all the Select attributes correctly.

review: Abstain

« Back to merge proposal