Code review comment for lp://staging/~jkakar/storm/resultselect
Revision history for this message
| Jamu Kakar (jkakar) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
9199653
demo site
(Get the code!)
> This is another crack at the problem, but using an expression
> instead of modifying the ResultSet API. I think this will solve the
> use cases we have without compromising the ResultSet API.
I'm planning to add more tests to make sure all the parameters
passed to super(ResultSelect, self).__init__ are handled correctly.
Before I do that I'd like to know if this basic approach is going to
be acceptable.