Storm

Merge lp://staging/~jkakar/storm/reference-set-order-by into lp://staging/storm

  1. reference-set-order-by
  2. Merge into trunk
Proposed by Jamu Kakar
Status: Merged
Approved by: Sidnei da Silva
Approved revision: 360
Merged at revision: 358
Proposed branch: lp://staging/~jkakar/storm/reference-set-order-by
Merge into: lp://staging/storm
Diff against target: 127 lines (+54/-6)
2 files modified
storm/references.py (+9/-3)
tests/store/base.py (+45/-3)
To merge this branch: bzr merge lp://staging/~jkakar/storm/reference-set-order-by
Reviewer Review Type Date Requested Status
Sidnei da Silva (community) Approve
Gustavo Niemeyer Approve
Review via email: mp+26476@code.staging.launchpad.net

Description of the change

This branch makes it possible to use a string, to work around
circular dependency issues, when defining the order_by property of a
ReferenceSet.

To post a comment you must log in.
Revision history for this message
Gustavo Niemeyer (niemeyer) wrote :

Nice, looks clear and good!

review: Approve
Revision history for this message
Sidnei da Silva (sidnei) wrote :

Looks great. +1!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: