Storm

Merge lp://staging/~jkakar/storm/infoheritance-doctest into lp://staging/storm

  1. infoheritance-doctest
  2. Merge into trunk
Proposed by Jamu Kakar
Status: Merged
Merge reported by: Jamu Kakar
Merged at revision: 264
Proposed branch: lp://staging/~jkakar/storm/infoheritance-doctest
Merge into: lp://staging/storm
To merge this branch: bzr merge lp://staging/~jkakar/storm/infoheritance-doctest
Reviewer Review Type Date Requested Status
James Henstridge Approve
Thomas Herve (community) Approve
Review via email: mp+820@code.staging.launchpad.net
To post a comment you must log in.
Revision history for this message
Thomas Herve (therve) wrote :

That's really cool. The only comment I have is about rollback and commit: it looks useless to me, I could remove all of them without failures.

review: Approve
Revision history for this message
James Henstridge (jamesh) wrote :

Looks good to me. I assume that the commit/rollback stuff is to try and drop the old objects from cache. I can't really think of a better way to do this more explicitly though.

Showing that the id() of the two objects differs wouldn't be appropriate, since id() is only guaranteed to uniquely identify the object while it is alive.

review: Approve
Revision history for this message
Jamu Kakar (jkakar) wrote :

That's right, the commit/rollback is to force Storm to reload
objects. I'll merge it as is.

Subscribers

People subscribed via source and target branches

to status/vote changes: