Landscape Client

Merge lp://staging/~jkakar/landscape-client/eliminate-pyflakes into lp://staging/~landscape/landscape-client/trunk

  1. eliminate-pyflakes
  2. Merge into trunk
Proposed by Jamu Kakar
Status: Merged
Approved by: Thomas Herve
Approved revision: 270
Merged at revision: 268
Proposed branch: lp://staging/~jkakar/landscape-client/eliminate-pyflakes
Merge into: lp://staging/~landscape/landscape-client/trunk
Diff against target: 294 lines (+11/-153)
10 files modified
Makefile (+3/-1)
landscape/broker/store.py (+0/-3)
landscape/conftest.py (+0/-123)
landscape/lib/amp.py (+2/-2)
landscape/manager/tests/test_customgraph.py (+1/-1)
landscape/monitor/mountinfo.py (+0/-1)
landscape/monitor/tests/test_temperature.py (+0/-1)
landscape/package/tests/test_store.py (+4/-4)
landscape/tests/helpers.py (+0/-16)
landscape/tests/test_watchdog.py (+1/-1)
To merge this branch: bzr merge lp://staging/~jkakar/landscape-client/eliminate-pyflakes
Reviewer Review Type Date Requested Status
Thomas Herve (community) Approve
Free Ekanayaka (community) Approve
Review via email: mp+28159@code.staging.launchpad.net

Description of the change

This branch introduces the following changes:

- All Pyflakes warnings, that aren't spurious, are fixed.

- The unused DBusHelper is removed.

- A duplicate Watchdog test has been uniquified.

To post a comment you must log in.
Revision history for this message
Free Ekanayaka (free.ekanayaka) wrote :

[1]

+ -pyflakes `find landscape -name \*py|grep -v amp\.py|grep -v twisted_amp\.py|grep -v configobj\.py|grep -v mocker\.py`

Any specific reason for excluding "amp.\py" ?

Looks great! +1

review: Approve
lp://staging/~jkakar/landscape-client/eliminate-pyflakes updated
270. By Jamu Kakar

- Removed 'amp.py' from the files excluded from pyflakes checks.

Revision history for this message
Thomas Herve (therve) wrote :

+1!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: