libappindicator

Merge lp://staging/~jjardon/libappindicator/fix-820080 into lp://staging/libappindicator

fix-820080
Merge into trunk

Proposed by Javier Jardón on 2011-09-21

Status:

Superseded

Proposed branch:

lp://staging/~jjardon/libappindicator/fix-820080

Merge into:

lp://staging/libappindicator

Diff against target:

82 lines (+7/-31)

1 file modified

src/app-indicator.c (+7/-31)

To merge this branch:

bzr merge lp://staging/~jjardon/libappindicator/fix-820080

Medium

Fix Released

Link a bug report

Reviewer	Date Requested	Status
Ted Gould (community)	2011-09-21	Disapprove on 2011-09-22
Andrea Cimitan (community)		Approve on 2011-09-22
Review via email: mp+76481@code.staging.launchpad.net

This proposal has been superseded by a proposal from 2011-09-22.

Revision history for this message

Andrea Cimitan (cimi) wrote on 2011-09-22:

I don't know which is the default coding style, but from the snippet I see you might want to remove the space between function names and their brackets

review: Approve

Revision history for this message

Ted Gould (ted) wrote on 2011-09-22:

While I agree that this is the "right" way to do it, GIcon support has been broken in GTK+ for a while and was causing upstream GNOME maintainers to claim our work was shoddy.

https://bugzilla.gnome.org/show_bug.cgi?id=614800

So that's why we stopped using it.

review: Disapprove

lp://staging/~jjardon/libappindicator/fix-820080 updated on 2011-09-22

215. By Javier Jardón on 2011-09-22

Do not append "-panel" to the given icon name if it's missing.

As the -panel variant can not exist. Also, GtkStatusIcon
support fixed-sized icons nowadays.

Fix https://bugs.launchpad.net/libappindicator/+bug/820080