Merge lp://staging/~jjardon/indicator-datetime/update_map into lp://staging/indicator-datetime/0.3
Proposed by
Javier Jardón
| Status: | Rejected |
|---|---|
| Rejected by: | Charles Kerr |
| Proposed branch: | lp://staging/~jjardon/indicator-datetime/update_map |
| Merge into: | lp://staging/indicator-datetime/0.3 |
| Diff against target: |
853 lines (+343/-228) 6 files modified
libmap/Makefile.am (+3/-1) libmap/cc-timezone-map.c (+44/-89) libmap/cc-timezone-map.h (+2/-4) libmap/test-timezone.c (+94/-49) libmap/tz.c (+196/-84) libmap/tz.h (+4/-1) |
| To merge this branch: | bzr merge lp://staging/~jjardon/indicator-datetime/update_map |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Charles Kerr (community) | Disapprove | ||
|
Review via email:
|
|||
To post a comment you must log in.
Unmerged revisions
- 140. By Javier Jardón
-
Handle GMT offsets as timezones
- 139. By Javier Jardón
-
libmap/Makefile.am: Add two missing timezone files
- 138. By Javier Jardón
-
libmap: Use GtkStyleContext instead deprecated GtkStyle
- 137. By Javier Jardón
-
libmap: sync cc-timezone-map code against upstream
- 136. By Javier Jardón
-
libmap: Update tz utilities
- 135. By Javier Jardón
-
libmap: Update maps with upstream
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
indicator-datetime uses an external dependency for this now (libtimezonemap), so we're no longer bundling libmap.
I appreciate you taking the time to make this patch. I think the code reviewers need to do a better job of handling these reviews in a timely manner so that conflicting patches like this have less chance of occurring.
The patch looks fine, but since it's now moot I'm going to pass on it.