Ubuntu
apport package

Merge lp://staging/~jibel/ubuntu/bionic/apport/lp1582950_2_ubiquity_hook into lp://staging/~ubuntu-core-dev/ubuntu/bionic/apport/ubuntu

Proposed by Jean-Baptiste Lallement on 2018-01-23

Status:	Merged
Approved by:	Brian Murray on 2018-01-30
Approved revision:	2604
Merged at revision:	2606
Proposed branch:	lp://staging/~jibel/ubuntu/bionic/apport/lp1582950_2_ubiquity_hook
Merge into:	lp://staging/~ubuntu-core-dev/ubuntu/bionic/apport/ubuntu
Diff against target:	25 lines (+7/-1) 1 file modified data/package-hooks/source_ubiquity.py (+7/-1)
To merge this branch:	bzr merge lp://staging/~jibel/ubuntu/bionic/apport/lp1582950_2_ubiquity_hook
Related bugs:	Link a bug report

Reviewer	Date Requested	Status
Brian Murray	2018-01-23	Needs Fixing on 2018-01-29
Ubuntu Core Development Team	2018-01-23	Pending
Review via email: mp+336474@code.staging.launchpad.net

Description of the change

source_ubiquity.py: Convert attachments to string when it is necessary.

Revision history for this message

Brian Murray (brian-murray) wrote on 2018-01-29:

Thanks for working on this. I believe isinstance() is preferred to using type().

https://docs.python.org/3/library/functions.html#type

Did you test this with both scenarios outlined in the bug?

review: Needs Fixing

lp://staging/~jibel/ubuntu/bionic/apport/lp1582950_2_ubiquity_hook updated on 2018-01-30

2604. By Jean-Baptiste Lallement on 2018-01-30: source_ubiquity.py: Use isinstance() instead of type()

Revision history for this message

Jean-Baptiste Lallement (jibel) wrote on 2018-01-30:

Thanks for your review.

I changed the code to use isinstance()

I tested on bionic on a live session and an installed system as user and as root with sudo and the hook did not crash while it is crashing without the patch.