Merge ~jibel/ubiquity:encryption_recovery_key into ubiquity:master
| Status: | Merged |
|---|---|
| Merge reported by: | Michael Hudson-Doyle |
| Merged at revision: | ea93e5b1aa4c43e34b64e72c9c382dc8d0d8630d |
| Proposed branch: | ~jibel/ubiquity:encryption_recovery_key |
| Merge into: | ubiquity:master |
| Diff against target: |
748 lines (+395/-70) 6 files modified
debian/changelog (+7/-0) debian/ubiquity.templates (+36/-2) gui/gtk/stepPartCrypto.ui (+268/-58) tests/test_gtkui.py (+2/-1) ubiquity/plugins/ubi-partman.py (+76/-9) ubiquity/validation.py (+6/-0) |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Didier Roche-Tolomelli (community) | Approve | ||
| Ubuntu Installer Team | Pending | ||
|
Review via email:
|
|||
Commit message
Make the recovery key editable and optional.
Make default recovery key 48 digits long.
Description of the change
This is an update of the recovery key feature that landed in previous release (21.04)
This updated version brings the following changes:
* the recovery key is optional.
* the recovery key is editable.
* the default recovery key is a 48 digits number.
It also fixes an issue where the recovery key fields were not displayed in manual partitioning mode with an encrypted partition.
The default key is now generated with 'secrets' instead of uuid4().
The layout of the UI has been adapted a bit to fit on a small screen but one test had to be updated to relax the constraint on the minimal screen height.
The package builds in a PPA:
https:/
The package has been tested in a VM on Ubuntu Desktop.
| Sebastien Bacher (seb128) wrote | # |
There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.
With latest changes, LGTM! Thanks.