Merge ~jibel/ubiquity:encryption_recovery_key into ubiquity:master
Status: | Merged | ||||
---|---|---|---|---|---|
Merged at revision: | 8774e460c1229f6ad38dacb3f1864a254c77cabb | ||||
Proposed branch: | ~jibel/ubiquity:encryption_recovery_key | ||||
Merge into: | ubiquity:master | ||||
Diff against target: |
932 lines (+481/-144) 8 files modified
debian/changelog (+10/-0) debian/ubiquity.templates (+49/-0) gui/gtk/stepPartCrypto.ui (+279/-143) scripts/plugininstall.py (+51/-0) tests/test_gtkui.py (+1/-0) ubiquity/components/plugininstall.py (+2/-1) ubiquity/misc.py (+8/-0) ubiquity/plugins/ubi-partman.py (+81/-0) |
||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Iain Lane (community) | Approve | ||
Ubuntu Installer Team | Pending | ||
Review via email: mp+397742@code.staging.launchpad.net |
Commit message
This adds supports for a recovery key on LUKS + LVM installation:
- Added an extra field for a recovery key in the password page when encryption is selected
- This field is RO and the key is digits only to enter it with a key pad
- The key is saved to a file on disk, so it can be stored in a safe place.
- This key can be used to unlock the device is the usual key is lost for some reason.
Tested on up to date hirsute:
1. Unlock with the default key.
2. Unlock with the master key.
Build in a PPA: https:/
There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.
Heya, sorry for the delay.
This looks mostly good to me. I've got some questions inline.
optional nitpick, which is probably already violated all over Ubiquity: Can we standardise on one for quotes in the changes made here? I see some instances of both " and '.
I've just looked at the code so far. I'll have a go at running it on Monday.