ubiquity

Merge ~jibel/ubiquity:remove_popcon into ubiquity:master

  1. Git
  2. lp:~jibel/ubiquity
  3. remove_popcon
  4. Merge into master
Proposed by Jean-Baptiste Lallement
Status: Merged
Merged at revision: c1621984dafb405b0284303111962c35cc1480c8
Proposed branch: ~jibel/ubiquity:remove_popcon
Merge into: ubiquity:master
Diff against target: 62 lines (+7/-12)
3 files modified
debian/changelog (+7/-1)
scripts/plugininstall.py (+0/-10)
ubiquity/i18n.py (+0/-1)
Reviewer Review Type Date Requested Status
Iain Lane (community) Approve
Review via email: mp+390882@code.staging.launchpad.net

Commit message

popularity-contest is not shipped anymore, remove it from the installer.

To post a comment you must log in.
Revision history for this message
Iain Lane (laney) wrote :

I'm good with this, but I'm guessing since we don't ship popcon anywhere currently we were always getting into the exception handler already?

Previously any flavour could enable popcon by seeding it, this will break that, but I think it's OK since the server is not maintained.

Please pull --rebase before pushing. I can't do that at my end because that will mean LP loses track of the merge.

review: Approve
Revision history for this message
Jean-Baptiste Lallement (jibel) wrote :

Thanks for the review.

Yes, that was the case, and on Ubuntu it generates systematically an error in the logs, thats how I noticed it.

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches