ubiquity

Merge ~jibel/ubiquity:zpool_use_persistent_path into ubiquity:master

Proposed by Jean-Baptiste Lallement on 2020-05-27

Status:

Merged

Approved by:

Jean-Baptiste Lallement on 2020-05-27

Approved revision:

36ea45160d00c9fd940b6d1b760e7a7b9b652625

Merged at revision:

36ea45160d00c9fd940b6d1b760e7a7b9b652625

Proposed branch:

~jibel/ubiquity:zpool_use_persistent_path

Merge into:

ubiquity:master

Diff against target:

33 lines (+14/-0)

2 files modified

debian/changelog (+6/-0)
scripts/zsys-setup (+8/-0)

Unknown

Link a bug report

Reviewer	Review Type	Date Requested	Status
Didier Roche-Tolomelli (community)		2020-05-27	Approve on 2020-05-27
Review via email: mp+384627@code.staging.launchpad.net

Commit message

Use persistent path for pool's vdevs

Devices names such a /dev/sdX may change on reboot and leads to unbootable systems.
This patch uses partuuid instead which is stable. We couldn't use uuid because it changes when the pool is created. (LP: #1880869)

Revision history for this message

Didier Roche-Tolomelli (didrocks) wrote on 2020-05-27:

+1 with your tests in the different environment :)

review: Approve

Revision history for this message

Jean-Baptiste Lallement (jibel) wrote on 2020-05-27:

For the report, this branch has been tested on VM and HW, with virtio and sata disks. I couldn't test with nvme drives.
I verified that zpool.cache is updated with the right paths and persists other several reboots.

Revision history for this message

Jean-Baptiste Lallement (jibel) wrote on 2020-05-27:

s/report/record/

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.