ubiquity

Merge ~jibel/ubiquity:lp1856863_2TB_drives_use_gpt into ubiquity:master

Proposed by Jean-Baptiste Lallement on 2020-01-06

Status:

Merged

Approved by:

Jean-Baptiste Lallement on 2020-01-06

Approved revision:

41a3b48a4cc4778da99c94c3bdd59671cabe1dab

Merged at revision:

41a3b48a4cc4778da99c94c3bdd59671cabe1dab

Proposed branch:

~jibel/ubiquity:lp1856863_2TB_drives_use_gpt

Merge into:

ubiquity:master

Diff against target:

87 lines (+28/-8)

2 files modified

debian/changelog (+9/-0)
scripts/zsys-setup (+19/-8)

High

Fix Released

Link a bug report

Reviewer	Date Requested	Status
Didier Roche-Tolomelli (community)	2020-01-06	Approve on 2020-01-06
Ubuntu Installer Team	2020-01-06	Pending
Review via email: mp+377179@code.staging.launchpad.net

Commit message

Drives bigger than 2TB use GPT but if the machine has been booted in legacy mode the ESP is not created. Rely on the label type instead of the firmware to know how to partition the disk (LP: #1856863)

Revision history for this message

Didier Roche-Tolomelli (didrocks) wrote on 2020-01-06:

2 small comments but the overall logic LGTM.

review: Needs Information

Revision history for this message

Jean-Baptiste Lallement (jibel) on 2020-01-06:

Revision history for this message

Jean-Baptiste Lallement (jibel) wrote on 2020-01-06:

MP updated following your comments

Revision history for this message

Didier Roche-Tolomelli (didrocks) wrote on 2020-01-06:

ack on the comment and the changes. LGTM. I didn't test myself but I think you did try it. It would be good to land that to have it in a daily. Thanks!

review: Approve

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.