Merge lp://staging/~jibel/synaptic/bug.153966.452564 into lp://staging/synaptic

Proposed by Jean-Baptiste Lallement
Status: Merged
Merged at revision: 1771
Proposed branch: lp://staging/~jibel/synaptic/bug.153966.452564
Merge into: lp://staging/synaptic
Diff against target: 224 lines (+123/-45)
3 files modified
common/rpackage.cc (+59/-32)
common/rpackage.h (+3/-0)
debian/patches/01_ubuntu_changelog.dpatch (+61/-13)
To merge this branch: bzr merge lp://staging/~jibel/synaptic/bug.153966.452564
Reviewer Review Type Date Requested Status
synaptic-developers Pending
Review via email: mp+23429@code.staging.launchpad.net

Description of the change

Tested with changelogs.ubuntu.com and medibuntu repo.

2 points still remains and need a fix:
- TODO: Need to use supportedOrigins instead of hard coded "Ubuntu". This is a problem for Debian.
- BUG: When pkgAcquire::Run() fails the item is not dequeued. Only visible if a changelog completely failed and the next succeeded, the messages are overwritten in the changelog dialog.

help would be much appreciated.

To post a comment you must log in.
Revision history for this message
Michael Vogt (mvo) wrote :

Thanks, diff looks good. For the todos:
1) is not too bad, the hardcoded value is there, but its all about LP, should prbably be a patch or a distro specific thing, but ok for now
2) sounds like a bug in libapt actually :/ Do you have steps to reproduce?

Revision history for this message
Michael Vogt (mvo) wrote :

Thanks! I merged it into the lucid branch, the next step is to merge into trunk/ and upload to debian.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: